Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dichotomy between stars and BH as central objects #653

Open
kslong opened this issue Dec 14, 2019 · 2 comments
Open

Dichotomy between stars and BH as central objects #653

kslong opened this issue Dec 14, 2019 · 2 comments
Assignees
Labels
bug Bugs in the code Release

Comments

@kslong
Copy link
Collaborator

kslong commented Dec 14, 2019

Models involving a star are not being reported correctly in define phot. Rather the luminosity is being reported as if it were an AGN. Curiously there was a similar issue in 2018 #329, but perhaps it was not completely fixed. Part of the issue here is that we no longer have a star or agn, but a central object. Some clean up needs to be done.

!! xdefine_phot: heating & cooling  due to adiabatic processes:         0.00e+00 0.00e+00 
!! xdefine_phot: lum_tot 1.28e+42 lum_star 0.00e+00 lum_disk 0.00e+00 lum_bl 0.00e+00 lum_agn 1.28e+42 lum_wind 0.00e+00
!! xdefine_phot:   f_tot 7.04e+40   f_star 0.00e+00   f_disk 0.00e+00   f_bl 0.00e+00   f_agn 7.04e+40   f_wind 0.00e+00   f_matom 0.00e+00   f_kpkt 0.00e+00 
!! xdefine_phot: wind ff 0.00e+00       fb 0.00e+00   lines  0.00e+00  for freq 1.00e+14 1.00e+15
!! xdefine_phot: star  tstar  0.00e+00   0.00e+00   lum_star 0.00e+00 0.00e+00  0.00e+00 
!! xdefine_phot: disk                               lum_disk 0.00e+00 0.00e+00  0.00e+00 
@kslong kslong added bug Bugs in the code Release labels Dec 14, 2019
@kslong
Copy link
Collaborator Author

kslong commented Dec 19, 2019

This issue here is that we treat in much of the code the AGN (or BH) as a separate object from the star, even though it is unlikely we will every have both in the same system. The question here is how far we want to go down the path of cleaning this up.

kslong added a commit that referenced this issue Dec 24, 2019
…654)

This just changes a few print statements so that the avoid specifically saying agn or star.  The underlying issue that we have not fully integrated the central object treatment, but still deal with stars and BH's separately still remains.
@kslong kslong changed the title Star luminoisities being reported correctly Dichotomy between stars and BH as central objects Jan 6, 2020
@kslong
Copy link
Collaborator Author

kslong commented Jan 6, 2020

This issue was in part about the way we report information in the log file, but that hides the larger issue of how we treat BH vs stars in side the program. I have renamed the issue to reflect the larger problem, but it's still not clear how to deal with this easily.

kslong pushed a commit that referenced this issue Jan 16, 2020
…653)

* mostly cleanup in macro_gov.c:

* further commenting to matom.c

* corrected line luminosity in py_wind for #643
@saultyevil saultyevil self-assigned this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in the code Release
Projects
None yet
Development

No branches or pull requests

2 participants