You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Models involving a star are not being reported correctly in define phot. Rather the luminosity is being reported as if it were an AGN. Curiously there was a similar issue in 2018 #329, but perhaps it was not completely fixed. Part of the issue here is that we no longer have a star or agn, but a central object. Some clean up needs to be done.
This issue here is that we treat in much of the code the AGN (or BH) as a separate object from the star, even though it is unlikely we will every have both in the same system. The question here is how far we want to go down the path of cleaning this up.
…654)
This just changes a few print statements so that the avoid specifically saying agn or star. The underlying issue that we have not fully integrated the central object treatment, but still deal with stars and BH's separately still remains.
kslong
changed the title
Star luminoisities being reported correctly
Dichotomy between stars and BH as central objects
Jan 6, 2020
This issue was in part about the way we report information in the log file, but that hides the larger issue of how we treat BH vs stars in side the program. I have renamed the issue to reflect the larger problem, but it's still not clear how to deal with this easily.
Models involving a star are not being reported correctly in define phot. Rather the luminosity is being reported as if it were an AGN. Curiously there was a similar issue in 2018 #329, but perhaps it was not completely fixed. Part of the issue here is that we no longer have a star or agn, but a central object. Some clean up needs to be done.
The text was updated successfully, but these errors were encountered: