Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup for macro routines #657

Merged
merged 4 commits into from
Jan 16, 2020
Merged

Cleanup for macro routines #657

merged 4 commits into from
Jan 16, 2020

Conversation

jhmatthews
Copy link
Collaborator

Mostly commenting.

Includes a few minor code changes, e.g., removing the double return statement in macro_gov() and ensuring that return is 0 not 1.

See #652

@jhmatthews jhmatthews requested a review from kslong January 16, 2020 11:14
@jhmatthews jhmatthews mentioned this pull request Jan 16, 2020
Closed
@jhmatthews
Copy link
Collaborator Author

Now also includes a fix in py_wind_ion.c with issue #643 to get the line luminosity result correct.

@kslong kslong merged commit cfb7a83 into sirocco-rt:dev Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kslong kslong Awaiting requested review from kslong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhmatthews @kslong