-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++/python] Updates for core 2.27 #3178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
[c++] Updates for core 2.27
[c++/python] Updates for core 2.27
Oct 16, 2024
johnkerl
force-pushed
the
kerl/fixes-for-2-27
branch
from
October 16, 2024 16:26
95e4109
to
15eed72
Compare
Co-authored-by: nguyenv <[email protected]>
johnkerl
force-pushed
the
kerl/fixes-for-2-27
branch
from
October 16, 2024 17:05
deb2ed1
to
245deb0
Compare
This includes #3179 I meant to:
However I merged #3179 into this one :| |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3178 +/- ##
==========================================
- Coverage 83.34% 83.29% -0.05%
==========================================
Files 51 51
Lines 5469 5483 +14
==========================================
+ Hits 4558 4567 +9
- Misses 911 916 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Key point here is test-unbreaks when someone points at
dev
of core which has some recent mods including TileDB-Inc/TileDB#5303#3364
Changes:
Make unit tests pass when core is recent
dev
, e.g. TileDB-Inc/centralized-tiledb-nightlies#24There is more to do on #2407 / [sc-51048] for Python and R both to incorporate new support for current domain in dense arrays.
Notes for Reviewer: