Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++/python] Updates for core 2.27 #3178

Merged
merged 7 commits into from
Oct 16, 2024
Merged

[c++/python] Updates for core 2.27 #3178

merged 7 commits into from
Oct 16, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 16, 2024

Issue and/or context: Key point here is test-unbreaks when someone points at dev of core which has some recent mods including TileDB-Inc/TileDB#5303

#3364

Changes:

Make unit tests pass when core is recent dev, e.g. TileDB-Inc/centralized-tiledb-nightlies#24

There is more to do on #2407 / [sc-51048] for Python and R both to incorporate new support for current domain in dense arrays.

Notes for Reviewer:

@johnkerl johnkerl changed the title [c++] Updates for core 2.27 [c++/python] Updates for core 2.27 Oct 16, 2024
@johnkerl johnkerl requested review from nguyenv and jp-dark October 16, 2024 16:13
@johnkerl johnkerl marked this pull request as ready for review October 16, 2024 16:14
@johnkerl johnkerl force-pushed the kerl/fixes-for-2-27 branch from 95e4109 to 15eed72 Compare October 16, 2024 16:26
@johnkerl johnkerl force-pushed the kerl/fixes-for-2-27 branch from deb2ed1 to 245deb0 Compare October 16, 2024 17:05
@johnkerl
Copy link
Member Author

This includes #3179

I meant to:

However I merged #3179 into this one :|

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.29%. Comparing base (b0154cb) to head (245deb0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3178      +/-   ##
==========================================
- Coverage   83.34%   83.29%   -0.05%     
==========================================
  Files          51       51              
  Lines        5469     5483      +14     
==========================================
+ Hits         4558     4567       +9     
- Misses        911      916       +5     
Flag Coverage Δ
python 83.29% <31.57%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.29% <31.57%> (-0.05%) ⬇️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 22aa800 into main Oct 16, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/fixes-for-2-27 branch October 16, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants