Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Support for current domain on dense arrays #3179

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 16, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes: Work off to-do items in the code

Notes for Reviewer:

@johnkerl johnkerl force-pushed the kerl/fixes-for-2-27 branch from 95e4109 to 15eed72 Compare October 16, 2024 16:26
@johnkerl johnkerl force-pushed the kerl/py-dense-curdom branch from 6f2bdc0 to 2f9c096 Compare October 16, 2024 16:27
@johnkerl johnkerl requested review from nguyenv and jp-dark October 16, 2024 16:28
@johnkerl johnkerl marked this pull request as ready for review October 16, 2024 16:28
apis/python/src/tiledbsoma/_dense_nd_array.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_tdb_handles.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_tdb_handles.py Outdated Show resolved Hide resolved
@johnkerl johnkerl merged commit deb2ed1 into kerl/fixes-for-2-27 Oct 16, 2024
@johnkerl johnkerl deleted the kerl/py-dense-curdom branch October 16, 2024 16:39
johnkerl added a commit that referenced this pull request Oct 16, 2024
johnkerl added a commit that referenced this pull request Oct 16, 2024
* Expose `embedded_version_triple` to `pybind11` layer

* fix up us-east-1 mod in pytest

* unit_soma_dense_ndarray.cc

* move have_dense_current_domain_support to test/common.cc

* unit_soma_collection.cc

* 2.26 testing

* [python] Support for current domain on dense arrays (#3179)

Co-authored-by: nguyenv <[email protected]>

---------

Co-authored-by: nguyenv <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants