Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable current domain on dense arrays. #5303

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Enable current domain on dense arrays. #5303

merged 5 commits into from
Oct 15, 2024

Conversation

DimitrisStaratzis
Copy link
Contributor

@DimitrisStaratzis DimitrisStaratzis commented Sep 12, 2024 •
edited by teo-tsirpanis
Loading

This PR enables the current domain feature in dense arrays

TYPE: FEATURE
DESC: Support current domain on dense arrays.

@DimitrisStaratzis DimitrisStaratzis marked this pull request as draft September 12, 2024 17:13
@DimitrisStaratzis DimitrisStaratzis marked this pull request as ready for review September 12, 2024 17:15
@DimitrisStaratzis DimitrisStaratzis changed the title Enable current domain for Dense. Enable current domain on dense arrays. Sep 12, 2024
teo-tsirpanis
teo-tsirpanis reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also update documentation in tiledb\api\c_api\array_schema\array_schema_api_experimental.h.

@DimitrisStaratzis
Copy link
Contributor Author

You should also update documentation in tiledb\api\c_api\array_schema\array_schema_api_experimental.h.

Done, thanks!

teo-tsirpanis
teo-tsirpanis approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

teo-tsirpanis
teo-tsirpanis reviewed Sep 17, 2024
View reviewed changes
test/src/test-cppapi-current-domain.cc Outdated Show resolved Hide resolved
test/src/test-cppapi-current-domain.cc Outdated Show resolved Hide resolved
@KiterLuc
Copy link
Contributor

@DimitrisStaratzis let's make a slightly more elaborate description to this PR.

@teo-tsirpanis teo-tsirpanis merged commit d632325 into dev Oct 15, 2024
64 checks passed
@teo-tsirpanis teo-tsirpanis deleted the dstara/sc-54482/support-current-domain-for-dense-arrays branch October 15, 2024 17:31
@jdblischak jdblischak mentioned this pull request Oct 16, 2024
Closed
This was referenced Oct 16, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bekadavis9 bekadavis9 bekadavis9 left review comments

@teo-tsirpanis teo-tsirpanis teo-tsirpanis approved these changes

@robertbindar robertbindar Awaiting requested review from robertbindar

@KiterLuc KiterLuc Awaiting requested review from KiterLuc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DimitrisStaratzis @KiterLuc @teo-tsirpanis @bekadavis9