-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Simplify internal API for dataframe-resizer #3090
Merged
johnkerl
merged 5 commits into
kerl/sdf-domain-at-create
from
kerl/maybe-resize-soma-joinid-cpp-tweak
Sep 30, 2024
Merged
[c++] Simplify internal API for dataframe-resizer #3090
johnkerl
merged 5 commits into
kerl/sdf-domain-at-create
from
kerl/maybe-resize-soma-joinid-cpp-tweak
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
requested review from
jp-dark,
nguyenv and
XanthosXanthopoulos
and removed request for
jp-dark
September 28, 2024 20:32
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## kerl/sdf-domain-at-create #3090 +/- ##
============================================================
Coverage ? 89.16%
============================================================
Files ? 45
Lines ? 4284
Branches ? 0
============================================================
Hits ? 3820
Misses ? 464
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/maybe-resize-soma-joinid-cpp-tweak
branch
from
September 28, 2024 20:38
89d98ef
to
0178ab5
Compare
johnkerl
force-pushed
the
kerl/maybe-resize-soma-joinid-cpp-tweak
branch
from
September 28, 2024 21:49
0178ab5
to
7981d82
Compare
…rsion (#3086) * Update the encoding version to 1.1.0 * Update errors for valid soma types that are not yet implemented
nguyenv
approved these changes
Sep 30, 2024
johnkerl
force-pushed
the
kerl/maybe-resize-soma-joinid-cpp-tweak
branch
from
September 30, 2024 16:59
7981d82
to
96f70e1
Compare
Thanks @nguyenv ! |
johnkerl
force-pushed
the
kerl/maybe-resize-soma-joinid-cpp-tweak
branch
from
September 30, 2024 17:48
96f70e1
to
3258070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
While the full-generality
upgrade_domain
is tasked out on #2407, the foremost use-case for append mode, andtests/testthat/test-write-soma-resume.R
for PR #3089, will need a simpller keystroke-saver which is already implemented in C++.What this existing method does in C++ is resize the
soma_joinid
dim, if it's a dim, and leave the other dims as-is; ifsoma_joinid
is not a dim, leave it as-is. This exists in C++, it's unit-tested in C++, and it's ready (and it's time) to be plumbed up to Python and R as well.I realize now that having C++
maybe_resize_joinid
take a length-1 vector, and assert that it's length-1, is silly -- it should simply take a singleint64_t
. This PR does just that. It also removes the confusing prefixmaybe_
.Notes for Reviewer: