Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Replace deprecated wheel.bdist_wheel with setuptools.command.bdist_wheel #3076

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

ryan-williams
Copy link
Member

Issue and/or context:

As of wheel>=44.0.0 (Aug '24), wheel.bdist_wheel warns:

warn(
    "The 'wheel' package is no longer the canonical location of the 'bdist_wheel' "
    "command, and will be removed in a future release. Please update to setuptools "
    "v70.1 or later which contains an integrated version of this command.",
    DeprecationWarning,
    stacklevel=1,
)

I've moved us to setuptools>=70.1 and setuptools.command.bdist_wheel here; hopefully this is a no-op / CI will surface any issues…

@ryan-williams ryan-williams force-pushed the rw/bdist branch 4 times, most recently from 7ea2277 to a830fda Compare September 26, 2024 19:54
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.94%. Comparing base (424c897) to head (7f95fc9).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3076      +/-   ##
==========================================
+ Coverage   89.79%   89.94%   +0.14%     
==========================================
  Files          41       41              
  Lines        4107     4107              
==========================================
+ Hits         3688     3694       +6     
+ Misses        419      413       -6     
Flag Coverage Δ
python 89.94% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.94% <ø> (+0.14%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@ryan-williams ryan-williams marked this pull request as ready for review September 26, 2024 21:37
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ryan-williams ryan-williams merged commit 87672ce into main Sep 30, 2024
35 checks passed
@ryan-williams ryan-williams deleted the rw/bdist branch September 30, 2024 14:26
johnkerl added a commit that referenced this pull request Sep 30, 2024
* Use core 2.26.2 (#3096)

* [python/r/c++] Update allowed soma types and the metadata encoding version (#3086)

* Update the encoding version to 1.1.0
* Update errors for valid soma types that are not yet implemented

* replace deprecated `wheel.bdist_wheel` with `setuptools.command.bdist_wheel` (#3076)

* [c++] Add `SOMAMultiscaleImage` class (#3094)

Add `SOMAMultiscaleImage` to `libtiledbsoma`.

* [c++] Simplify internal API for dataframe-resizer

---------

Co-authored-by: Julia Dark <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants