-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python/r] DataFrame
resizer
#3091
Conversation
0178ab5
to
7981d82
Compare
0ca52b0
to
49a2b21
Compare
9c64a11
to
a66595a
Compare
7981d82
to
96f70e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good on the Python side. Just one minor comment.
Thanks @nguyenv ! |
96f70e1
to
3258070
Compare
1531119
to
27dc91f
Compare
6692a88
to
eeade29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from R, a few minor comments to be a bit more R-tastic but nothing major
9269614
to
39db38b
Compare
a418265
to
7fad794
Compare
e55735b
to
2b4d5a0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3091 +/- ##
===========================================
- Coverage 88.98% 62.46% -26.53%
===========================================
Files 45 108 +63
Lines 4287 13288 +9001
Branches 0 825 +825
===========================================
+ Hits 3815 8301 +4486
- Misses 472 4788 +4316
- Partials 0 199 +199
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
While the full-generality
upgrade_domain
is on track for #2407, the most important special case is resizing thesoma_joinid
index column and leaving the others alone, ifsoma_joinid
is an index column -- otherwise leaving it alone.This already exists in C++ and is well-tested there. This PR simply connects it to Python/R. It's time for this, as we need:
tests/testthat/test-soma-write-resume.R
for R on [r] MakeDataFrame
objects shapeable at ingest #3089tiledbsoma.io
[WIP] #2964Notes for Reviewer: