Fix window resizing/moving issues and add ability to disable vibrancy #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It didn’t fix all cases and prevented app’s window from being resized/moved.
….sidebar-vibrancy.
Updated selectors to use new vibrancy ones (‘sidebar-vibrancy’, ‘full-vibrancy’).
sindresorhus
changed the title
Merged
|
As requested, I've added the TODO comment regarding the default vibrancy setting and implemented the setting migration ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #721
Fixes #724
Fixes #725 by reverting a faulty fix (my bad).
Also, improves the situation in #712 by providing a way to disable the vibrancy.
In a way, this PR acts as a stop-gap before a complete fix for vibrancy issues is done (though some people might like the vibrancy-less look so an option for that is a plus).
cc: @sindresorhus, @neegool