Add emoji style setting

[mikigal]

Add option to use old Messenger emoji. You can enable it in options.

[CvX]

1. Emoji replacement shouldn't really be in setUpPrivacyBlocking. That code should have its own function instead.
2. The URL replacement algorithm is too complex because it not only changes the emoji style but also its size. If we keep the original size/pixel ratio (and I think we should), then the replacement comes down to just a single letter change, e.g. https://static.xx.fbcdn.net/images/emoji.php/v9/tf8/2/32/1f61b.png becomes https://static.xx.fbcdn.net/images/emoji.php/v9/zf8/2/32/1f61b.png ('t' -> 'z')
3. As far as I know there are three styles available: 't' (the current default), 'z', and 'f' (e.g. https://static.xx.fbcdn.net/images/emoji.php/v9/ff8/2/32/1f61b.png). Should we offer all three?

[mikigal]

I think we can offer thee types of emoji, user will can select it in menu.
I will follow your suggestions.

[mikigal]

I've created menu with 3 emoji options, separated emoji code from setUpPrivacyBlocking. I haven't idea to name options so I simply name it 'F style', etc.

[CvX]

@mikigal I've added more fixed and slightly reorganized the code. Please take a look if everything looks good to you. 🙂

Before we merge, I have some questions:

1. Is *://*.${domain}/images/emoji.php/v9 needed here?

   caprine/index.js

   Line 151 in f4eabac

   const filter = {urls: ['*://static.xx.fbcdn.net/images/emoji.php/v9/*', `*://*.${domain}/images/emoji.php/v9`]};

2. We probably should handle in some way emoji that isn't available in older emoji sets, right? Currently using the latest emoji ends up like this:
3. This one is to @sindresorhus – should menu options like this be all placed in "Caprine > Caprine Preferences"? I feel like at least some of them should be moved to e.g. "View" or "Window".

[mikigal]

1. Emoji can be fetched from facebook.com too. I'm not sure when it fetch from static.xx.fbcdn.net or facebook.com. It can't be downloaded from messenger.com. I replace {domain} to facebook.com for additional safety.

2. I created exclude list. It is needed only for Messenger 1.0 version. For these emoji we don’t do anything and give emoji from newest version. For Facebook 2.2 everything seems to work.
   I changed default emoji style to the newest version too.

I think everything is correct now :)

[mikigal]

It seem's it can be only one webRequest.onBeforeRequest. It seems second onBeforeRequest override first, and privacy blocking didn't worked, because emoji override it. I worked around it by creating one onBeforeRequest that trigger privacy blocking and emoji methods. Now everything works :)

[CvX]

You're right about webRequest.onBeforeRequest! I just assumed it allows registering multiple listeners… Should have read the docs! 😄

I'm pushing more changes:

• Added more emoji codes to the excludes list (Facebook 3.0 set introduced 161 new emojis), removed duplicates and sorted it alphanumerically
• cleaned up the code and extracted it again to the separate file (who knew it would grow so much 😜)

Let me know if I broke anything again. 😉

Also, two more questions:

1. What's the reason for these changes?

   caprine/index.js

   Lines 426 to 436 in f07aef9

   	if (mainWindow !== undefined) {
   	mainWindow.show();
   	}
   	});
   	app.on('before-quit', () => {
   	isQuitting = true;
   	if (mainWindow !== undefined) {
   	config.set('lastWindowState', mainWindow.getNormalBounds());
   	}

2. Since changing active emoji set requires app restart, should we display a message box offering a restart?

[CvX]

Oh, and because of all those new emoji I've enabled emoji replacement for Facebook 2.2 set. Without it, the support is kinda spotty:

[mikigal]

Oh, this changes was for test, because I have another problem with Caprine, and it seems to help. I committed it in mistake, sorry. I think alert with restart option is good idea. Currently I don't have idea why emoticons works in menu, but crash after send. I will check it tomorrow.

[mikigal]

I don't know why, but I haven't any problems with emoji from your screenshot. Please check by devtools(F12) from what URL it tries download.

[CvX]

Oh, they do work now (when using fallback). I'm just saying I've enabled the excludes list for Facebook 2.2 set because these were previously missing in e.g. 8f961df and f07aef9. Or did these work for you before my recent commits?

[mikigal]

It worked for me, without exclude list for Facebook 2.2. But I found something interesting. It looks, that facebook automatically redirect some emoji from FB 2.2 (I think all missing for this set) to FB 3.0. It's why I made exclude list only for 1.0

[CvX]

That's how our replacement shows up in DevTools. 🙂

[mikigal]

Not every! There are a lot of downloaded emoji without any redirect, but from selected set. It's strange but it seems that facebook redirect it automatically. So does we need exclude list for FB2.0 too?

[mikigal]

@CvX Can you add comment how to get all excludes?

[CvX]

All requested changes have been made. (shouldn't Github automatically mark the review green?)

Though I have a question to @sindresorhus that got lost in the discussion:

3. should menu options like this be all placed in "Caprine > Caprine Preferences"? I feel like at least some of them should be moved to e.g. "View" or "Window".

Anyway, that's a non-blocker. LGTM 🙂

[sindresorhus]

3. should menu options like this be all placed in "Caprine > Caprine Preferences"? I feel like at least some of them should be moved to e.g. "View" or "Window".

Yeah, I missed that. No, Preferences is correct. "View" and "Window" should only contain transient and context-sensitive actions, meaning actions you do often and that are not meant to be permanent. You could argue the Vibrancy thing should be in Preferences too.

[sindresorhus]

Can you fix the merge conflict?

[sindresorhus]

Maybe we should move this and other related logic to module.exports = {emoji} in emoji.js to contain all the logic for this feature in one file?

[CvX]

That was a good idea! Done. Let me know how do you like the new code organization.