Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vibrancy issue, gray sidebar #712

Closed
hieuhuynh93 opened this issue Jan 10, 2019 · 13 comments · Fixed by #1070
Closed

Vibrancy issue, gray sidebar #712

hieuhuynh93 opened this issue Jan 10, 2019 · 13 comments · Fixed by #1070

Comments

@hieuhuynh93
Copy link

I didn't use Dark mode and Vibrancy mode, but the sidebar is look like dark mode. Please check my screenshot. Thank you.
Screenshot

@sindresorhus
Copy link
Owner

// @neegool

@dscos
Copy link

dscos commented Jan 10, 2019

I am experiencing this same issue, but in reverse: Main window is obeying my dark area selection but the sidebar is light with light text.

@cocoJambon01
Copy link

I have a similar issue I might say. Turning Dark Mode on will neglect the sidebar and only the message box will be black: http://prntscr.com/m5ttm7

@mikigal
Copy link
Contributor

mikigal commented Jan 11, 2019

I have the same problem. Chat box is dark and list in white. Temporary solution is using version 2.23.0 with removed silent auto-updater. You have to remove it and compile code manual. I removed updater from release from Github, you can download it from my website if you won't do it yourself :) I compiled only for macOS. Download link (you have to click unicorn to start downloading):
https://loveani.me/caprine-2.23.0-removed-updater.zip

@filipruisl
Copy link

same here, however the Sidebar is a Dark vibrant theme with dark text on it.

@ggrelet
Copy link
Contributor

ggrelet commented Jan 12, 2019

I have a similar issue, however I don't even have Dark Mode enabled. The white mode's white is simply different in the side bar.
screenshot_2019-01-12 15-02-25 2x

Edit: spelling.

@cocoJambon01
Copy link

Just installed version 2.26 - Issue persists.

@jackwilsdon
Copy link

Yeah I can confirm this is still broken on master. This patch seems to fix it but vibrancy mode still doesn't look right with dark mode enabled;

diff --git dark-mode.css dark-mode.css
index 570862b..344a1f2 100644
--- dark-mode.css
+++ dark-mode.css
@@ -764,8 +764,7 @@ html.os-darwin.dark-mode ._673w {
 }
 
 /* Styles for vibrancy in dark mode */
-html.os-darwin.dark-mode body,
-html.os-darwin.dark-mode ._4sp8 {
+html.os-darwin.dark-mode body {
 	background: transparent !important;
 }

Dark Mode
Dark Mode

Dark Mode + Full-Window Vibrancy
Dark Mode + Full-Window Vibrancy

@sindresorhus
Copy link
Owner

// @CvX

@sindresorhus sindresorhus reopened this Jan 14, 2019
@hieuhuynh93
Copy link
Author

I confirmed that the issue is still not solve yet. (2.26.0)
Screenshot

@CvX
Copy link
Collaborator

CvX commented Jan 16, 2019

I've submitted PR #727 which allows to completely disable vibrancy in case you have any issues with vibrancy or if you just prefer the vibrancy-less look.

@ggrelet, @hieuhuynh93 – the app in your screenshots looks correct, that was the default look since Caprine 2.24.0. After #727 is merged and released you'll be able to go back to pre-2.24 look if you wish (by selecting "View -> Vibrancy -> No Vibrancy")

I'll continue to work on the original issue, I'm currently knee deep in Electron/Chromium code… 😅

@hieuhuynh93
Copy link
Author

hieuhuynh93 commented Jan 19, 2019

Thanks @CvX
The issue has been solved.
Imgur

@CvX CvX changed the title What's happen with the sidebar? Vibrancy issue, gray sidebar Feb 13, 2019
@rachelyhe
Copy link
Contributor

rachelyhe commented Mar 2, 2019

This patch seems to fix it but vibrancy mode still doesn't look right with dark mode enabled;

It seems that vibrancy grays out (and is essentially the same gray as vibrancy in Light mode) everything except links at the moment. [EDIT: screenshot is Dark Mode > Full-window Vibrancy]

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants