Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clubhouse #2169

Closed
wants to merge 8 commits into from
Closed

Add Clubhouse #2169

wants to merge 8 commits into from

Conversation

ehsanghaffar
Copy link

[https://github.com/ehsanghaffarii/awesome-clubhouse]

[A list of tools and resources for Clubhouse social audio app]

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • add Swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The title of your entry should be title-cased and the URL to your list should end in #readme.
    • Example: - [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
    • Must not feature Contributing or Footnotes sections.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
    • It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
    • The section should not appear in the Table of Contents.
  • All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't use hard-wrapping.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

@sindresorhus
Copy link
Owner

Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

Copy link
Author

@ehsanghaffar ehsanghaffar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed lint errors on this commit #2169

Copy link

@abenhamdine abenhamdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For information, the lint check only gives errors of your edit in awesome readme itself, but you should also run awesome-lint on your own repo, see sindresorhus/awesome-lint

@ehsanghaffar
Copy link
Author

For information, the lint check only gives errors of your edit in awesome readme itself, but you should also run awesome-lint on your own repo, see sindresorhus/awesome-lint

Thanks for the update, I will fix it and make sure that does not have problems to send. 🙌🏼

@michelpereira
Copy link
Contributor

@ehsanghaffarii I checked the lint erros and pushed a PR for you:
ehsanghaffar/awesome-clubhouse#1

@ehsanghaffar
Copy link
Author

@ehsanghaffarii I checked the lint erros and pushed a PR for you: ehsanghaffarii/awesome-clubhouse#1

ok, Thanks for fixing it. I merged your PR

@RobertCharles1988
Copy link

RobertCharles1988 commented Feb 7, 2022 via email

Copy link
Author

@ehsanghaffar ehsanghaffar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed all lint errors, please check and review 🙏🏼

@RobertCharles1988
Copy link

RobertCharles1988 commented Feb 7, 2022 via email

Copy link

@abenhamdine abenhamdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • AnyHouse : the description is mostly in Chinese
  • "Tech & Chill", "Startup Club", "Tech Talks" : descriptions are missing
  • code snippets : I'm not sure code snippets are allowed in the list, it should probably be hosted in separated pages

readme.md Outdated
@@ -238,6 +238,7 @@
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole.
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services.
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills.
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A list of best tools, APIs, and resources for Clubhouse The social audio app.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "the Clubhouse social app"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right 👍

@janpeuker
Copy link

In the main list, I believe there should be no "Contributing" section at the bottom of the readme.

@ehsanghaffar
Copy link
Author

Contributing

Thank you for pointing. Done 👍🏼

@riderx
Copy link
Contributor

riderx commented Feb 22, 2022

@ehsanghaffarii don't forget to review Pr of others !
Mine is waiting some review :
#2161

@riderx
Copy link
Contributor

riderx commented Feb 22, 2022

And the magic word :)

@riderx riderx mentioned this pull request Feb 22, 2022
@sindresorhus
Copy link
Owner

It is a good source, practical and rich in content - #2161 (comment)

This does not count as a review comment. Review comments are supposed to comment on how the list should improve.

@eozer
Copy link
Contributor

eozer commented Mar 10, 2022

Hi,

Thank you @ehsanghaffarii for awesome-clubhouse. Please find my review.

CH Bio Generator - CH bio generator is a must-have app for those who are actively using Clubhouse and want to increase their followers on Clubhouse.

It may be better to use "CH Bio Generator" (notice the casing) to indicate the tool in the sentence. It seems you have used this casing in different items. So it would also be more consistent.

Border of Clubhouse - Border for Clubhouse: Clubring is a mobile app that, just as the name says, allows you to create and save various rings around your profile photo.

I think this needs some rewording. It would be simpler to just say maybe, "A mobile app that allows you to create and save various rings around your profile photo."

API Collection - Insomnia API collection.

Question. Is this Clubhouse collection API in Insomnia format? Better description would be good here.

Python API - Clubhouse cli API create with Python.

CLI*, created*/written in Python*

Open Clubhouse - A third-part web application based on flask to play Clubhouse audio.

I think you meant "third-party" here. I would also change casing to "Flask".

AnyHouse - AnyHouse,A Chines client of clubhouse.

Rewriting may be needed. Maybe say just "A Chines client of Clubhouse"?

Programming
Python - Coding and programming enthusiasts, Feel free to start rooms! Open to all levels! Suggest your friends as members!
JavaScript - JavaScript is the everywhere language; one of the most popular programming languages in the world.
Persian Developers Hub - A community of developers who share their knowledge and experience in the field of web development.
Programmers - Persian Developers club.

The last two items are descriptive enough. I am not so sure about the first two items. They are more slogan like. However, they are self-evident though; it is about Python programming language club. It would be nice if these two items were more like the others.

Human Behaviour - This club is for everyone interested in - neuroscience/ decision-making, health/ wellness, tech/ computer science, marketing/ influence, start-ups/ VC.

I understood the description is from the link. But, could it be better if we drop slash and just use comma?

@eozer eozer mentioned this pull request Mar 10, 2022
@ehsanghaffar
Copy link
Author

Hi,

Thank you @ehsanghaffarii for awesome-clubhouse. Please find my review.

CH Bio Generator - CH bio generator is a must-have app for those who are actively using Clubhouse and want to increase their followers on Clubhouse.

It may be better to use "CH Bio Generator" (notice the casing) to indicate the tool in the sentence. It seems you have used this casing in different items. So it would also be more consistent.

Border of Clubhouse - Border for Clubhouse: Clubring is a mobile app that, just as the name says, allows you to create and save various rings around your profile photo.

I think this needs some rewording. It would be simpler to just say maybe, "A mobile app that allows you to create and save various rings around your profile photo."

API Collection - Insomnia API collection.

Question. Is this Clubhouse collection API in Insomnia format? Better description would be good here.

Python API - Clubhouse cli API create with Python.

CLI*, created*/written in Python*

Open Clubhouse - A third-part web application based on flask to play Clubhouse audio.

I think you meant "third-party" here. I would also change casing to "Flask".

AnyHouse - AnyHouse,A Chines client of clubhouse.

Rewriting may be needed. Maybe say just "A Chines client of Clubhouse"?

Programming
Python - Coding and programming enthusiasts, Feel free to start rooms! Open to all levels! Suggest your friends as members!
JavaScript - JavaScript is the everywhere language; one of the most popular programming languages in the world.
Persian Developers Hub - A community of developers who share their knowledge and experience in the field of web development.
Programmers - Persian Developers club.

The last two items are descriptive enough. I am not so sure about the first two items. They are more slogan like. However, they are self-evident though; it is about Python programming language club. It would be nice if these two items were more like the others.

Human Behaviour - This club is for everyone interested in - neuroscience/ decision-making, health/ wellness, tech/ computer science, marketing/ influence, start-ups/ VC.

I understood the description is from the link. But, could it be better if we drop slash and just use comma?

Hi,
Thanks a lot for the review.
I tried to follow your recommendations and add better explanations for the links. I hope it is efficient.

@sindresorhus sindresorhus force-pushed the main branch 2 times, most recently from 0fdf977 to ec33c66 Compare May 14, 2022 09:40
@sindresorhus
Copy link
Owner

Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

For example, ElectronJS is incorrect.

readme.md Outdated
@@ -240,6 +240,7 @@
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole.
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services.
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills.
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A useful of tools, APIs, and resources for the Clubhouse social app.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is incorrect. Please read the guidelines.

@sindresorhus
Copy link
Owner

Item descriptions should not be title-cased.

@sindresorhus
Copy link
Owner

You should not commit this: https://github.com/ehsanghaffarii/awesome-clubhouse/blob/main/.DS_Store

readme.md Outdated Show resolved Hide resolved
@benjaminsehl benjaminsehl mentioned this pull request Jul 11, 2022
@ParsaDj
Copy link

ParsaDj commented Aug 25, 2022

Thank you for this amazing brief description, amazing and informative. Thanks for making an Awesome list! 🙌🏻

@0Lola
Copy link
Contributor

0Lola commented Aug 29, 2022

Hi @ehsanghaffar,

The list is clear and useful!
Here are some of the points that maybe can help you:

  • awesome-lint check a lint error : List item description must end with proper punctuation.

❌ The description of Clubhouse Desktop lost a . .

@ehsanghaffar
Copy link
Author

Hi @ehsanghaffar,

The list is clear and useful! Here are some of the points that maybe can help you:

  • awesome-lint check a lint error : List item description must end with proper punctuation.

❌ The description of Clubhouse Desktop lost a . .

Thanks for the review, it's ok now

@@ -240,6 +240,7 @@
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole.
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services.
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills.
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A tools list for work with Clubhouse API.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your entry here should include a short description about the project/theme of the list. It should not describe the list itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.