-
-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clubhouse #2169
Add Clubhouse #2169
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed lint errors on this commit #2169
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For information, the lint check only gives errors of your edit in awesome readme itself, but you should also run awesome-lint on your own repo, see sindresorhus/awesome-lint
Thanks for the update, I will fix it and make sure that does not have problems to send. 🙌🏼 |
@ehsanghaffarii I checked the lint erros and pushed a PR for you: |
ok, Thanks for fixing it. I merged your PR |
Ok will do
Robert C. Ozuna
…On Sun, Feb 6, 2022, 5:59 PM Ehsan Ghaffar ***@***.***> wrote:
@ehsanghaffarii <https://github.com/ehsanghaffarii> I checked the lint
erros and pushed a PR for you: ehsanghaffar/awesome-clubhouse#1
<ehsanghaffar/awesome-clubhouse#1>
ok, Thanks for fixing it. I merged your PR
—
Reply to this email directly, view it on GitHub
<#2169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXOQ7E7PXENJADLZ74KFKQDUZ4KNRANCNFSM5NFQIYZA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed all lint errors, please check and review 🙏🏼
I am
Robert C. Ozuna
…On Sun, Feb 6, 2022, 6:14 PM Ehsan Ghaffar ***@***.***> wrote:
***@***.**** commented on this pull request.
I fixed all lint errors, please check and review 🙏🏼
—
Reply to this email directly, view it on GitHub
<#2169 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXOQ7E5OQA4BIHDZVDFZWLTUZ4MF7ANCNFSM5NFQIYZA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- AnyHouse : the description is mostly in Chinese
- "Tech & Chill", "Startup Club", "Tech Talks" : descriptions are missing
- code snippets : I'm not sure code snippets are allowed in the list, it should probably be hosted in separated pages
readme.md
Outdated
@@ -238,6 +238,7 @@ | |||
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole. | |||
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services. | |||
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills. | |||
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A list of best tools, APIs, and resources for Clubhouse The social audio app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "the Clubhouse social app"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's right 👍
In the main list, I believe there should be no "Contributing" section at the bottom of the readme. |
Thank you for pointing. Done 👍🏼 |
@ehsanghaffarii don't forget to review Pr of others ! |
And the magic word :) |
This does not count as a review comment. Review comments are supposed to comment on how the list should improve. |
Hi, Thank you @ehsanghaffarii for awesome-clubhouse. Please find my review.
It may be better to use "CH Bio Generator" (notice the casing) to indicate the tool in the sentence. It seems you have used this casing in different items. So it would also be more consistent.
I think this needs some rewording. It would be simpler to just say maybe, "A mobile app that allows you to create and save various rings around your profile photo."
Question. Is this Clubhouse collection API in Insomnia format? Better description would be good here.
CLI*, created*/written in Python*
I think you meant "third-party" here. I would also change casing to "Flask".
Rewriting may be needed. Maybe say just "A Chines client of Clubhouse"?
The last two items are descriptive enough. I am not so sure about the first two items. They are more slogan like. However, they are self-evident though; it is about Python programming language club. It would be nice if these two items were more like the others.
I understood the description is from the link. But, could it be better if we drop slash and just use comma? |
Hi, |
0fdf977
to
ec33c66
Compare
For example, |
readme.md
Outdated
@@ -240,6 +240,7 @@ | |||
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole. | |||
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services. | |||
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills. | |||
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A useful of tools, APIs, and resources for the Clubhouse social app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is incorrect. Please read the guidelines.
Item descriptions should not be title-cased. |
You should not commit this: https://github.com/ehsanghaffarii/awesome-clubhouse/blob/main/.DS_Store |
Thank you for this amazing brief description, amazing and informative. Thanks for making an Awesome list! 🙌🏻 |
Hi @ehsanghaffar, The list is clear and useful!
❌ The description of Clubhouse Desktop lost a |
Thanks for the review, it's ok now |
@@ -240,6 +240,7 @@ | |||
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole. | |||
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services. | |||
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills. | |||
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A tools list for work with Clubhouse API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your entry here should include a short description about the project/theme of the list. It should not describe the list itself.
[https://github.com/ehsanghaffarii/awesome-clubhouse]
[A list of tools and resources for Clubhouse social audio app]
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.