-
-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hydrogen #2289
Add Hydrogen #2289
Conversation
Adds: ```md - [Hydrogen](https://github.com/shopify/awesome-hydrogen#readme) - Edge-first framework for building Shopify storefronts with React ```
@benjaminsehl You have to review at least 2 other open pull requests.
|
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Sorry about that @sindresorhus! Working through these now and will update the PR. |
Thanks for the feedback @sindresorhus / @prokopsimek — I've reviewed two other open PR's with feedback on which pieces they were missing. We also updated our Awesome List to include the contributing and license files, and we fixed our formatting errors. |
I have reviewed #2099 (as referenced in #2320) & #2169 @sindresorhus — while the author of #2320 went with my suggestion, you asked not to do that. I will continue to monitor the pull requests to add proper suggestions in case this does not count as two different reviews. Please let me know if there is anything else I've missed on the above — I believe I've now followed all of the guidelines correctly. |
|
My first time reviewing, but based on the PR checklist this list looks The list has been open for 30+ days, it's got the proper tags, badge, and contributing guidelines, and includes a TOC and succinct yet clear summaries. And, while not one of the criteria, I personally found the list helpful. |
unicorn |
@sindresorhus Just curious what I'm missing here. Happy to do whatever you need to get this merged! |
Adds:
[Insert URL to the list here]
https://github.com/shopify/awesome-hydrogen#readme
[Explain what this list is about and why it should be included here]
This list is to help users of the Hydrogen framework find relevant tools and resources to help them accelerate their build. It is a place for us to show off the best of the community and various integrations with the Hydrogen framework.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.