-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clubhouse #393
Add Clubhouse #393
Conversation
@-sindresorhus on 2022-01-31 08:08 says: Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
@-ehsanghaffar on 2022-02-02 13:15 says:
Thanks for the update, I will fix it and make sure that does not have problems to send. 🙌🏼 |
@-michelpereira on 2022-02-06 23:28 says: @-ehsanghaffarii I checked the lint erros and pushed a PR for you: |
@-ehsanghaffar on 2022-02-07 00:51 says:
ok, Thanks for fixing it. I merged your PR |
@-RobertCharles1988 on 2022-02-07 01:04 says: Ok will do Robert C. Ozuna On Sun, Feb 6, 2022, 5:59 PM Ehsan Ghaffar @.***> wrote:
|
@-RobertCharles1988 on 2022-02-07 01:15 says: I am Robert C. Ozuna On Sun, Feb 6, 2022, 6:14 PM Ehsan Ghaffar @.***> wrote:
|
@-janpeuker on 2022-02-07 11:43 says: In the main list, I believe there should be no "Contributing" section at the bottom of the readme. |
@-ehsanghaffar on 2022-02-07 12:23 says:
Thank you for pointing. Done 👍🏼 |
@-riderx on 2022-02-22 14:22 says: @-ehsanghaffarii don't forget to review Pr of others ! |
@-riderx on 2022-02-22 14:23 says: And the magic word :) |
@-sindresorhus on 2022-03-02 08:22 says:
This does not count as a review comment. Review comments are supposed to comment on how the list should improve. |
@-eozer on 2022-03-10 17:07 says: Hi, Thank you @-ehsanghaffarii for awesome-clubhouse. Please find my review.
It may be better to use "CH Bio Generator" (notice the casing) to indicate the tool in the sentence. It seems you have used this casing in different items. So it would also be more consistent.
I think this needs some rewording. It would be simpler to just say maybe, "A mobile app that allows you to create and save various rings around your profile photo."
Question. Is this Clubhouse collection API in Insomnia format? Better description would be good here.
CLI*, created*/written in Python*
I think you meant "third-party" here. I would also change casing to "Flask".
Rewriting may be needed. Maybe say just "A Chines client of Clubhouse"?
The last two items are descriptive enough. I am not so sure about the first two items. They are more slogan like. However, they are self-evident though; it is about Python programming language club. It would be nice if these two items were more like the others.
I understood the description is from the link. But, could it be better if we drop slash and just use comma? |
@-ehsanghaffar on 2022-03-11 03:20 says:
Hi, |
@-sindresorhus on 2022-06-02 14:01 says:
For example, |
@-sindresorhus on 2022-06-02 14:01 says: Item descriptions should not be title-cased. |
@-sindresorhus on 2022-06-02 14:04 says: You should not commit this: https://github.com/ehsanghaffarii/awesome-clubhouse/blob/main/.DS_Store |
@-ParsaDj on 2022-08-25 07:08 says: Thank you for this amazing brief description, amazing and informative. Thanks for making an Awesome list! 🙌🏻 |
@-0Lola on 2022-08-29 06:23 says: Hi @-ehsanghaffar, The list is clear and useful!
❌ The description of Clubhouse Desktop lost a |
@-ehsanghaffar on 2022-08-30 00:20 says:
Thanks for the review, it's ok now |
readme.md
Outdated
@@ -240,6 +238,7 @@ | |||
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole. | |||
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services. | |||
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills. | |||
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A list of best tools, APIs, and resources for Clubhouse The social audio app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@-janpeuker on 2022-02-07 11:42 says: Should this be "the Clubhouse social app"?
readme.md
Outdated
@@ -240,6 +238,7 @@ | |||
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole. | |||
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services. | |||
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills. | |||
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A list of best tools, APIs, and resources for Clubhouse The social audio app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@-ehsanghaffar on 2022-02-07 11:44 says: Yes, that's right 👍
readme.md
Outdated
@@ -240,6 +240,7 @@ | |||
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole. | |||
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services. | |||
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills. | |||
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A useful of tools, APIs, and resources for the Clubhouse social app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@-sindresorhus on 2022-06-02 14:01 says: This description is incorrect. Please read the guidelines.
readme.md
Outdated
@@ -240,6 +240,7 @@ | |||
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole. | |||
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services. | |||
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills. | |||
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - helpful tools, and resources for developers and users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@-benjaminsehl on 2022-07-11 15:10 says:
Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase…
This description both describes the list, instead of the project, the first character should also start in a capital.
readme.md
Outdated
@@ -240,6 +240,7 @@ | |||
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole. | |||
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services. | |||
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills. | |||
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A tools list for work with Clubhouse API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@-sindresorhus on 2022-09-27 08:47 says:
Your entry here should include a short description about the project/theme of the list. It should not describe the list itself.
Pull request from @ehsanghaffar.
[ boilerplate snipped ]