Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clubhouse #393

Merged
merged 10 commits into from
Oct 31, 2022
Merged

Add Clubhouse #393

merged 10 commits into from
Oct 31, 2022

Conversation

0exbot
Copy link

@0exbot 0exbot commented Oct 31, 2022

Pull request from @ehsanghaffar.

[ boilerplate snipped ]

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-sindresorhus on 2022-01-31 08:08 says: Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-ehsanghaffar on 2022-02-02 13:15 says:

For information, the lint check only gives errors of your edit in awesome readme itself, but you should also run awesome-lint on your own repo, see sindresorhus/awesome-lint

Thanks for the update, I will fix it and make sure that does not have problems to send. 🙌🏼

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-michelpereira on 2022-02-06 23:28 says: @-ehsanghaffarii I checked the lint erros and pushed a PR for you:
ehsanghaffar/awesome-clubhouse#1

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-ehsanghaffar on 2022-02-07 00:51 says:

@-ehsanghaffarii I checked the lint erros and pushed a PR for you: ehsanghaffarii/awesome-clubhouse#1

ok, Thanks for fixing it. I merged your PR

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-RobertCharles1988 on 2022-02-07 01:04 says: Ok will do

Robert C. Ozuna

On Sun, Feb 6, 2022, 5:59 PM Ehsan Ghaffar @.***> wrote:

@-ehsanghaffarii https://github.com/ehsanghaffarii I checked the lint
erros and pushed a PR for you: ehsanghaffar/awesome-clubhouse#1
ehsanghaffar/awesome-clubhouse#1

ok, Thanks for fixing it. I merged your PR


Reply to this email directly, view it on GitHub
sindresorhus/awesome#2169 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXOQ7E7PXENJADLZ74KFKQDUZ4KNRANCNFSM5NFQIYZA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-RobertCharles1988 on 2022-02-07 01:15 says: I am

Robert C. Ozuna

On Sun, Feb 6, 2022, 6:14 PM Ehsan Ghaffar @.***> wrote:

@.**** commented on this pull request.

I fixed all lint errors, please check and review 🙏🏼


Reply to this email directly, view it on GitHub
sindresorhus/awesome#2169 (review),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXOQ7E5OQA4BIHDZVDFZWLTUZ4MF7ANCNFSM5NFQIYZA
.
You are receiving this because you commented.Message ID:
@.***>

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-janpeuker on 2022-02-07 11:43 says: In the main list, I believe there should be no "Contributing" section at the bottom of the readme.

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-ehsanghaffar on 2022-02-07 12:23 says:

Contributing

Thank you for pointing. Done 👍🏼

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-riderx on 2022-02-22 14:22 says: @-ehsanghaffarii don't forget to review Pr of others !
Mine is waiting some review :
sindresorhus/awesome#2161

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-riderx on 2022-02-22 14:23 says: And the magic word :)

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-sindresorhus on 2022-03-02 08:22 says:

It is a good source, practical and rich in content - sindresorhus/awesome#2161 (comment)

This does not count as a review comment. Review comments are supposed to comment on how the list should improve.

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-eozer on 2022-03-10 17:07 says: Hi,

Thank you @-ehsanghaffarii for awesome-clubhouse. Please find my review.

CH Bio Generator - CH bio generator is a must-have app for those who are actively using Clubhouse and want to increase their followers on Clubhouse.

It may be better to use "CH Bio Generator" (notice the casing) to indicate the tool in the sentence. It seems you have used this casing in different items. So it would also be more consistent.

Border of Clubhouse - Border for Clubhouse: Clubring is a mobile app that, just as the name says, allows you to create and save various rings around your profile photo.

I think this needs some rewording. It would be simpler to just say maybe, "A mobile app that allows you to create and save various rings around your profile photo."

API Collection - Insomnia API collection.

Question. Is this Clubhouse collection API in Insomnia format? Better description would be good here.

Python API - Clubhouse cli API create with Python.

CLI*, created*/written in Python*

Open Clubhouse - A third-part web application based on flask to play Clubhouse audio.

I think you meant "third-party" here. I would also change casing to "Flask".

AnyHouse - AnyHouse,A Chines client of clubhouse.

Rewriting may be needed. Maybe say just "A Chines client of Clubhouse"?

Programming
Python - Coding and programming enthusiasts, Feel free to start rooms! Open to all levels! Suggest your friends as members!
JavaScript - JavaScript is the everywhere language; one of the most popular programming languages in the world.
Persian Developers Hub - A community of developers who share their knowledge and experience in the field of web development.
Programmers - Persian Developers club.

The last two items are descriptive enough. I am not so sure about the first two items. They are more slogan like. However, they are self-evident though; it is about Python programming language club. It would be nice if these two items were more like the others.

Human Behaviour - This club is for everyone interested in - neuroscience/ decision-making, health/ wellness, tech/ computer science, marketing/ influence, start-ups/ VC.

I understood the description is from the link. But, could it be better if we drop slash and just use comma?

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-ehsanghaffar on 2022-03-11 03:20 says:

Hi,

Thank you @-ehsanghaffarii for awesome-clubhouse. Please find my review.

CH Bio Generator - CH bio generator is a must-have app for those who are actively using Clubhouse and want to increase their followers on Clubhouse.

It may be better to use "CH Bio Generator" (notice the casing) to indicate the tool in the sentence. It seems you have used this casing in different items. So it would also be more consistent.

Border of Clubhouse - Border for Clubhouse: Clubring is a mobile app that, just as the name says, allows you to create and save various rings around your profile photo.

I think this needs some rewording. It would be simpler to just say maybe, "A mobile app that allows you to create and save various rings around your profile photo."

API Collection - Insomnia API collection.

Question. Is this Clubhouse collection API in Insomnia format? Better description would be good here.

Python API - Clubhouse cli API create with Python.

CLI*, created*/written in Python*

Open Clubhouse - A third-part web application based on flask to play Clubhouse audio.

I think you meant "third-party" here. I would also change casing to "Flask".

AnyHouse - AnyHouse,A Chines client of clubhouse.

Rewriting may be needed. Maybe say just "A Chines client of Clubhouse"?

Programming
Python - Coding and programming enthusiasts, Feel free to start rooms! Open to all levels! Suggest your friends as members!
JavaScript - JavaScript is the everywhere language; one of the most popular programming languages in the world.
Persian Developers Hub - A community of developers who share their knowledge and experience in the field of web development.
Programmers - Persian Developers club.

The last two items are descriptive enough. I am not so sure about the first two items. They are more slogan like. However, they are self-evident though; it is about Python programming language club. It would be nice if these two items were more like the others.

Human Behaviour - This club is for everyone interested in - neuroscience/ decision-making, health/ wellness, tech/ computer science, marketing/ influence, start-ups/ VC.

I understood the description is from the link. But, could it be better if we drop slash and just use comma?

Hi,
Thanks a lot for the review.
I tried to follow your recommendations and add better explanations for the links. I hope it is efficient.

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-sindresorhus on 2022-06-02 14:01 says:

Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

For example, ElectronJS is incorrect.

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-sindresorhus on 2022-06-02 14:01 says: Item descriptions should not be title-cased.

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-sindresorhus on 2022-06-02 14:04 says: You should not commit this: https://github.com/ehsanghaffarii/awesome-clubhouse/blob/main/.DS_Store

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-ParsaDj on 2022-08-25 07:08 says: Thank you for this amazing brief description, amazing and informative. Thanks for making an Awesome list! 🙌🏻

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-0Lola on 2022-08-29 06:23 says: Hi @-ehsanghaffar,

The list is clear and useful!
Here are some of the points that maybe can help you:

  • awesome-lint check a lint error : List item description must end with proper punctuation.

❌ The description of Clubhouse Desktop lost a . .

@0exbot
Copy link
Author

0exbot commented Oct 31, 2022

@-ehsanghaffar on 2022-08-30 00:20 says:

Hi @-ehsanghaffar,

The list is clear and useful! Here are some of the points that maybe can help you:

  • awesome-lint check a lint error : List item description must end with proper punctuation.

❌ The description of Clubhouse Desktop lost a . .

Thanks for the review, it's ok now

readme.md Outdated
@@ -240,6 +238,7 @@
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole.
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services.
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills.
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A list of best tools, APIs, and resources for Clubhouse The social audio app.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@-janpeuker on 2022-02-07 11:42 says: Should this be "the Clubhouse social app"?

readme.md Outdated
@@ -240,6 +238,7 @@
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole.
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services.
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills.
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A list of best tools, APIs, and resources for Clubhouse The social audio app.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@-ehsanghaffar on 2022-02-07 11:44 says: Yes, that's right 👍

readme.md Outdated
@@ -240,6 +240,7 @@
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole.
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services.
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills.
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A useful of tools, APIs, and resources for the Clubhouse social app.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@-sindresorhus on 2022-06-02 14:01 says: This description is incorrect. Please read the guidelines.

readme.md Outdated
@@ -240,6 +240,7 @@
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole.
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services.
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills.
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - helpful tools, and resources for developers and users.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@-benjaminsehl on 2022-07-11 15:10 says:

Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase

This description both describes the list, instead of the project, the first character should also start in a capital.

readme.md Outdated
@@ -240,6 +240,7 @@
- [Integration](https://github.com/stn1slv/awesome-integration#readme) - Linking together different IT systems (components) to functionally cooperate as a whole.
- [Node-RED](https://github.com/naimo84/awesome-nodered#readme) - A programming tool for wiring together hardware devices, APIs, and online services.
- [Low Code](https://github.com/zenitysec/awesome-low-code#readme) - Allowing business professionals to address their needs on their own with little to no coding skills.
- [Clubhouse](https://github.com/ehsanghaffarii/awesome-clubhouse#readme) - A tools list for work with Clubhouse API.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@-sindresorhus on 2022-09-27 08:47 says:

Your entry here should include a short description about the project/theme of the list. It should not describe the list itself.

@akvadrako akvadrako merged commit c8b76dc into main Oct 31, 2022
@akvadrako akvadrako deleted the pull/2169 branch October 31, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants