Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A preview update is not triggered on reorder #547

Closed
ScopeyNZ opened this issue Dec 11, 2018 · 3 comments
Closed

A preview update is not triggered on reorder #547

ScopeyNZ opened this issue Dec 11, 2018 · 3 comments
Labels
affects/v4 complexity/medium impact/medium type/bug

Comments

@ScopeyNZ
Copy link
Contributor

Affected version:

4.x

Description

Currently when performing actions on blocks the preview will update after the action so that you get live preview of the changes you're making. When dragging around blocks to re-order there is no change being triggered

Steps to reproduce

  • Create/edit a blocks page
  • Make at least two blocks with content
  • Observe the preview and note the order of blocks
  • Re-order the blocks by dragging around blocks
  • Note there's no update to the preview
  • Trigger an update by publishing (or refreshing)
  • Note that the preview updates in this case and shows the correct order of blocks.
@robbieaverill
Copy link
Contributor

Is this another manifestation of "modifying blocks doesn't update the page status"?

@ScopeyNZ
Copy link
Contributor Author

The page status not being updated is probably expected (because of the existence of silverstripe/silverstripe-versioned#195). This is talking about the preview side-panel explicitly though - which we still have to trigger a change on - something we've done for the existing save mechanisms.

@ScopeyNZ ScopeyNZ changed the title An update is not triggered on reorder A preview update is not triggered on reorder Dec 17, 2018
ScopeyNZ added a commit to creative-commoners/silverstripe-elemental that referenced this issue Dec 18, 2018
@ScopeyNZ
FIX Adding some page updates after sorting:
905fa80 
- The status of the block (switching to unpublished/draft) now correctly changes
- An update of the preview is triggered
- Fixes an issue where required props were not being provided to ElementActions in a test

Fixes silverstripe#547
This was referenced Dec 18, 2018
Merged
Closed
@ScopeyNZ
Copy link
Contributor Author

Closed in #553

@brynwhyman brynwhyman mentioned this issue May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/medium impact/medium type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ScopeyNZ @robbieaverill