Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing sort-order does not get published. #177

Closed
bummzack opened this issue Jan 22, 2018 · 9 comments
Closed

Changing sort-order does not get published. #177

bummzack opened this issue Jan 22, 2018 · 9 comments

Comments

@bummzack
Copy link

Steps to reproduce:

  1. Add some content-blocks
  2. Publish everything
  3. Sort the blocks to a different order
  4. Publish the page again

While step 3 creates the proper sort order in the Element table, it does not get propagated to Element_Live upon publishing the page.
Editing a single element and publishing it will properly update the sort order in the live table (but only for that element, all the others will still have the wrong value).

@robbieaverill
Copy link
Contributor

Hey @bummzack, ca you please provide the versions you're using? Thanks

@bummzack
Copy link
Author

Yeah, sorry:
dnadesign/silverstripe-elemental: dev-master 49b8c14
silverstripe/elemental-blocks: dev-master cbfa21b
silverstripe/recipe-cms: 1.0.1

So basically the latest stable SS4 and both current master-branches of silverstripe-elemental and elemental-blocks.

@robbieaverill
Copy link
Contributor

Thanks!

@NightJar
Copy link
Contributor

NightJar commented Feb 9, 2018

Hi @bummzack - I cannot reproduce this issue on the latest master sorry.
2.x-dev @ 995c775


Whoops no, turns out I can! (forgot to set the correct viewing stage!)

@NightJar
Copy link
Contributor

NightJar commented Feb 9, 2018

So looks like this is actually an issue with symbiote/silverstripe-gridfieldextensions and a small bug with SS4 silverstripe/versioned compatiblity.
It was fixed by symbiote/silverstripe-gridfieldextensions#243 - however this is only on the master branch, where as dnadesign/silverstripe-elemental will install ^3.1 - this is an issue because the current master branch will eventually be stabilised as a new 4.x line.

You can of course use this in the mean time, but we are looking to release a 3.2.0 of gridfieldextensions to get around this without a dependency major version bump.

@robbieaverill
Copy link
Contributor

You can update gridfieldextensions to 3.1.1 to get the fix for this https://github.com/symbiote/silverstripe-gridfieldextensions/releases/tag/3.1.1

@sirjeff
Copy link

sirjeff commented May 6, 2020

Hey just letting you know I have the same problem. Sort order is ok in stage but not live.
In stage the order is correct : 1,2,3,4,5,6,7,8 , but in the Element_Live table it shows as 1,2,2,3,3,4,5,5

silverstripe/recipe-cms - 4.5.0@stable
dnadesign/silverstripe-elemental - 4
symbiote/silverstripe-gridfieldextensions - 3.2

@sirjeff
Copy link

sirjeff commented May 6, 2020

I tried dnadesign/silverstripe-elemental - 4.0 same problem, so I jumped to
dnadesign/silverstripe-elemental - 4.3
and now the order is saving correctly in Live. I had to change the order a few times before it kicked in though.
But "yah" it's working!

@brynwhyman
Copy link

Hey @sirjeff I definitely recall this being a problem in previous versions of dnadesign/silverstripe-elemental 4.x but as you say it should be resolved now.

Some related issues and PRs that are now closed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants