FIX Adding some page updates after sorting: #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The status of the block (switching to unpublished/draft) now correctly changes - An update of the preview is triggered - Fixes an issue where required props were not being provided to ElementActions in a test Fixes silverstripe#547
NightJar
approved these changes
Dec 18, 2018
| @@ -57,7 +59,10 @@ class ElementEditor extends PureComponent { | |||
| handleDragEnd(sourceId, afterId) { | |||
| const { actions: { handleSortBlock }, areaId } = this.props; | |||
|
|
|||
| handleSortBlock(sourceId, afterId, areaId); | |||
| handleSortBlock(sourceId, afterId, areaId).then(() => { | |||
| const preview = window.jQuery('.cms-preview'); | |||
There was a problem hiding this comment.
Just a thought - this doesn't have any handling for where this selector doesn't match. I suppose that means you won't be able to use Elemental outside of the CMS (e.g. in a ModelAdmin). We should be careful to handle edge cases like this I think
There was a problem hiding this comment.
Yes that's reasonable and I agree. While I was doing this I was thinking it would be nice to consolidate a lot of this "entwine hack" code into some lib js file. Preferably available in admin or something. There's a bunch of places we use this code now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #547