ENHANCEMENT: Add nested fields, args, distribute args to fields #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
unclecheese
force-pushed
the
pulls/1.2/sense-and-extensibility
branch
from
0d25271 to
df538e8
Compare
robbieaverill
approved these changes
Oct 15, 2018
|
Also the commits could do with being squashed (during the necessary rebase), and the PR could be re-targetted at the 1.3 branch |
unclecheese
force-pushed
the
pulls/1.2/sense-and-extensibility
branch
from
1366eaf to
9e80ebe
Compare
chillu
reviewed
Oct 16, 2018
| ]; | ||
| addFields(path = ROOT_FIELD, fields = []) { | ||
| let fieldArray = []; | ||
| path.split('/').forEach(part => { |
There was a problem hiding this comment.
Is that an invalid symbol in GraphQL field names? I mean, it'd be a pretty weird field name, but who knows :D
There was a problem hiding this comment.
Yeah, deliberately so, because the / is a DSL for nested field names. Had to choose a character that was invalid.
chillu
reviewed
Oct 16, 2018
| @@ -73,6 +77,44 @@ describe('ApolloGraphqlManager', () => { | |||
| expect(fields).toContain('fest'); | |||
| }); | |||
|
|
|||
| it('adds nested fields', () => { | |||
| const manager = createMock(); | |||
| manager.addFields('root', ['FirstName', 'Surname']); | |||
There was a problem hiding this comment.
In terms of API, it feels a bit weird to have "root" as a mandated argument. I would've done the function signature the other way around. addFields(fields, path?), just assume root, and start deeper paths there (foo/bar rather than root/foo/bar)
raissanorth
pushed a commit
to creative-commoners/silverstripe-admin
that referenced
this pull request
Oct 18, 2018
…erstripe#683) * New api for adding fields, args * Linting * Build * Get tests for new args, fields manager API * Rebase against 1 * Update doc blocks and indentation * Rebase against 1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #611
NB: Ignore the branch name. Was originally done against 1.2, but have rebased to 1.