DOCS: New nested fields, args for ApolloGraphQLManager #8469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| @@ -1080,13 +1080,67 @@ Now, let's update the query to fetch our new field. | |||
| *my-other-app/client/transformReadNotes.js* | |||
| ```js | |||
| const transformReadNotes = (manager) => { | |||
| manager.addField('Priority'); | |||
| manager.addField('root', 'Priority'); | |||
There was a problem hiding this comment.
This is obviously an API break, and while I know we don't really treat our React API surface with semver yet, this does seem like it would break for anyone who had read these docs in the past and used the example code. Could you switch the argument order to make it B/C?
There was a problem hiding this comment.
I've picked up on this in my review as well. Apart from API breakages (which I'm less worried about for those early stage APIs), I think it's too verbose. See silverstripe/silverstripe-admin#683 (comment). We should declare any API breakages on unstable APIs like this clearly in our upgrading notes though.
robbieaverill
approved these changes
Oct 15, 2018
unclecheese
force-pushed
the
pulls/4/sense-and-extensibility
branch
from
99a457c to
3fcbead
Compare
robbieaverill
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves silverstripe/silverstripe-admin#611