Fixed the url for Broken logo #126
Conversation
There was a problem hiding this comment.
Line 86 in a85f938
bundlesize/store/views/build.pug
Line 8 in 7d1a9e3
I guess we should change these also
|
@kuldeepkeshwar Thanks for the review! I already changed those files as well. Total of 3 files changed. |
|
This is still missing Line 86 in a85f938 |
|
also not sure if we need it in the readme, but ig it won't do any harm |
|
Sidenote: Please don't add Sid as reviewer until further notice, as he is on break for sometime and had unwatched this repo. So, most probably he will not be able to review anything, as mentioned in #121 Regards! |
|
@kuldeepkeshwar Sorry for tagging sid! I completely forgot. I modified the |
|
@cg-cnu can you check it again as I can still see |
|
@kuldeepkeshwar I thought deleting the file and commiting again will help. I guess I created some conflicts. Can you guide me on this one. Sorry for the trouble. 😞 |
|
@cg-cnu @kuldeepkeshwar I can still see the lock on the diffs |
|
@SaraVieira Can you point out how I can remove it ? Or you think I should scrap this and create a fresh pr ? |
|
@cg-cnu Are you using npm 5? |
|
@SaraVieira Yes am on npm5. Sure will do that. Thanks 😄 |
|
@cg-cnu Awesome! I will update danger to also check for changes in the lock and give you these instructions :) |
|
@cg-cnu Awesome! I'm going to approve this and as soon as it's merged I'll do a patch release 🎉 |
|
@ForsakenHarmony @kuldeepkeshwar I think it looks great now |
|
@SaraVieira Thanks so much for helping me out 😄 Just trying to understand, I shouldn't push the package-lock.json (even if it has changes) unless I made any changes in the package.json and npm installs. |
|
@cg-cnu I believe so, I will enable greenkeeper in this repo so that we can get warnings when there new releases of stuff so that we are always up to date and that does not happen again :) |
|
@SaraVieira Shouldn't we add And when we update any package or add a new package, we can explicitly add |
|
@kakadiadarpan we could but that might bring issues in the future in Travis :/ |
|
we don't even need I will be opening an issue for the same to discuss on it. |
| @@ -1,5 +1,5 @@ | |||
| <p align="center"> | |||
| <img src="https://raw.githubusercontent.com/siddharthkp/bundlesize/master/art/logo.png" height="200px"/> | |||
| <img src="https://cdn.rawgit.com/siddharthkp/bundlesize/master/art/logo.png" height="200px"/> | |||
There was a problem hiding this comment.
cdn.rawgit redirects to raw.githubusercontent itself. Please revert this change. it is not necessary.
| @@ -82,7 +82,7 @@ This makes it great for using with applications that are bundled with another to | |||
|
|
|||
| #### 2) build status | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
same here.
cdn.rawgit redirects to raw.githubusercontent itself. Please revert this change. it is not necessary.
| @@ -5,7 +5,7 @@ | |||
| <link href="https://fonts.googleapis.com/css?family=Nunito" rel="stylesheet"> | |||
| </head> | |||
| <body> | |||
| <img class="logo" src="https://raw.githubusercontent.com/siddharthkp/bundlesize/master/art/logo.png"/> | |||
| <img class="logo" src="https://cdn.rawgit.com/siddharthkp/bundlesize/master/art/logo.png"/> | |||
| @@ -5,7 +5,7 @@ | |||
| <link href="https://fonts.googleapis.com/css?family=Nunito" rel="stylesheet"> | |||
| </head> | |||
| <body> | |||
| <img class="logo" src="https://raw.githubusercontent.com/siddharthkp/bundlesize/master/art/logo.png"/> | |||
| <img class="logo" src="https://cdn.rawgit.com/siddharthkp/bundlesize/master/art/logo.png"/> | |||
|
@reznord Wait! I am totally lost. I guess the request was to move the urls from |
right. but if you see, |
|
The purpose of using rawgit seems to be to get correct |
|
@reznord @cg-cnu @kuldeepkeshwar Patch release, everyone agree ? |
|
@SaraVieira Sounds good 👍 |
|
Done guys: Thanks you so much 🎉 |
|
@reznord BTW I'm asking for details about this redirect as I didn't expect this behavior. :) rgrove/rawgit#2 |
|
Cool! Will keep a track of it :) |
Description
Url returning 503, fixed it by changing it to rawgit.
Motivation and Context
Fixes #125
Types of changes