Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package-lock.json #128

Closed
reznord opened this issue Aug 30, 2017 · 1 comment
Closed

Remove package-lock.json #128

reznord opened this issue Aug 30, 2017 · 1 comment

Comments

@reznord
Copy link
Collaborator

reznord commented Aug 30, 2017

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Right now we are including package-lock.json in the repo and adding it will just make the things harder like keeping the package-lock.json up to date every time. I agree that using package-lock.json makes it easy and happy for users with npm>5. But this is a trade-off which we have to consider.

What is the expected behavior?
Remove package-lock.json from the repo.

Please mention other relevant information.

  • node version: 8.2.1
  • npm version: 5.x
  • Operating system: macOS
@palashmon
Copy link
Collaborator

I think we can remove it. But, again as @SaraVieira has mentioned in #126 (comment), we might or might not get issues in the future in Travis CI.

I think this has to be a ongoing test process to figure if it would be future proof like:

  1. Create a test repo or branch for this purpose.
  2. Add package-lock.json to .gitignore on this branch
  3. Add few dependencies and dev depedencies in package.json.
  4. Add few commits based on this new package.json
  5. See if the CI build is passing.
  6. Add few more dependencies and dev depedencies in package.json and remove some of the old ones.
  7. Repeat steps 4-5

@reznord reznord closed this as completed Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants