Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(coverage): fix coverage issues #139

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Conversation

nfischer
Copy link
Member

These issues are pointed out by the latest version of nyc. Fixing these
issues brings us to 100% coverage (as of [email protected]).

Fixes include:

  • ignore coverage for a condition we don't hit during testing
  • branch coverage for when we read stdin for commands with non-boolean
    options (e.g., head, tail)
  • branch coverage for plugin-behavior with config files lacking a
    plugin attribute

Issue #134

These issues are pointed out by the latest version of nyc. Fixing these
issues brings us to 100% coverage (as of [email protected]).

Fixes include:

 * ignore coverage for a condition we don't hit during testing
 * branch coverage for when we read stdin for commands with non-boolean
   options (e.g., head, tail)
 * branch coverage for plugin-behavior with config files lacking a
   plugin attribute

Issue #134
@freitagbr
Copy link
Contributor

LGTM

@codecov-io
Copy link

codecov-io commented Jun 21, 2018

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #139   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          25     25           
=====================================
  Hits           25     25
Impacted Files Coverage Δ
src/shx.js 100% <ø> (ø) ⬆️
src/config.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d7b8b...795f143. Read the comment docs.

@nfischer nfischer merged commit 4a29102 into master Jun 21, 2018
@nfischer nfischer deleted the test-fix-coverage-problems branch June 21, 2018 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants