chore: bump dev dependencies to resolve install warnings #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For comparison, here's what a fresh install looks like after this PR: $ rm -rf node_modules/
$ npm install
npm WARN prepublish-on-install As of npm@5, `prepublish` scripts are deprecated.
npm WARN prepublish-on-install Use `prepare` for build steps and `prepublishOnly` for upload-only.
npm WARN prepublish-on-install See the deprecation note in `npm help scripts` for more information.
> [email protected] prepublish [path redacted]/shx
> npm run build
> [email protected] prebuild [path redacted]/shx
> rimraf lib
> [email protected] build [path redacted]/shx
> babel src -d lib
src/cli.js -> lib/cli.js
src/config.js -> lib/config.js
src/help.js -> lib/help.js
src/printCmdRet.js -> lib/printCmdRet.js
src/shx.js -> lib/shx.js
added 649 packages in 13.346s |
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 4 +1
Lines 25 68 +43
=====================================
+ Hits 25 68 +43
Continue to review full report at Codecov.
|
|
The coverage change looks like a bug with |
|
And I think v10.0.0 introduced a change where config.js:47 is also marked as uncovered: |
freitagbr
approved these changes
Jun 20, 2018
|
LGTM |
nfischer
force-pushed
the
chore-bump-deps
branch
from
9f20465 to
18eb42e
Compare
|
Newsflash! The new nyc version is not buggy--those were real coverage issues. Uploaded #139 to fix those (and marking this as blocked by that PR). |
This bumps codecov to avoid depending on graceful-fs < v4. Test: npm ls graceful-fs (nothing below v4)
nfischer
force-pushed
the
chore-bump-deps
branch
from
18eb42e to
3e7fefd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps several dev dependencies to avoid depending on deprecated packages.
This also adds
package-lock.jsonto eliminate those warnings and the hassleinvolved with constantly removing the uncommitted file.
Issue #134