Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of warnings when installing #134

Open
nfischer opened this issue Jun 8, 2018 · 1 comment
Open

Lots of warnings when installing #134

nfischer opened this issue Jun 8, 2018 · 1 comment

Comments

@nfischer
Copy link
Member

nfischer commented Jun 8, 2018

When I do a fresh install, I see tons of install warnings (due to deprecated packages):

$ rm -rf node_modules/
$ npm install

npm WARN deprecated [email protected]: 🙌  Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!
npm WARN deprecated [email protected]: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated [email protected]: to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.

> [email protected] install [path redacted]/shx/node_modules/execSync
> node install.js

[execsync v1.0.2] Attempting to compile native extensions.
[execSync v1.0.2]
    Native code compile failed!!
npm WARN prepublish-on-install As of npm@5, `prepublish` scripts are deprecated.
npm WARN prepublish-on-install Use `prepare` for build steps and `prepublishOnly` for upload-only.
npm WARN prepublish-on-install See the deprecation note in `npm help scripts` for more information.

> [email protected] prepublish [path redacted]/shx
> npm run build


> [email protected] prebuild [path redacted]/shx
> rimraf lib


> [email protected] build [path redacted]/shx
> babel src -d lib

src/cli.js -> lib/cli.js
src/config.js -> lib/config.js
src/help.js -> lib/help.js
src/printCmdRet.js -> lib/printCmdRet.js
src/shx.js -> lib/shx.js
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 690 packages in 22.104s

Of these issues, graceful-fs is probably the most pressing (updating codecov resolves this).

@nfischer nfischer self-assigned this Jun 8, 2018
nfischer added a commit that referenced this issue Jun 20, 2018
These issues are pointed out by the latest version of nyc. Fixing these
issues brings us to 100% coverage (as of [email protected]).

Fixes include:

 * ignore coverage for a condition we don't hit during testing
 * branch coverage for when we read stdin for commands with non-boolean
   options (e.g., head, tail)
 * branch coverage for plugin-behavior with config files lacking a
   plugin attribute

Issue #134
nfischer added a commit that referenced this issue Jun 21, 2018
These issues are pointed out by the latest version of nyc. Fixing these
issues brings us to 100% coverage (as of [email protected]).

Fixes include:

 * ignore coverage for a condition we don't hit during testing
 * branch coverage for when we read stdin for commands with non-boolean
   options (e.g., head, tail)
 * branch coverage for plugin-behavior with config files lacking a
   plugin attribute

Issue #134
nfischer added a commit that referenced this issue Jun 25, 2018
This bumps several dev dependencies to avoid depending on deprecated packages.
This also adds `package-lock.json` to eliminate those warnings and the hassle
involved with constantly removing the uncommitted file.

Issue #134
@nfischer
Copy link
Member Author

nfischer commented Jul 4, 2018

Last thing to fix is:

npm WARN prepublish-on-install As of npm@5, `prepublish` scripts are deprecated.
npm WARN prepublish-on-install Use `prepare` for build steps and `prepublishOnly` for upload-only.
npm WARN prepublish-on-install See the deprecation note in `npm help scripts` for more information.

The correct fix is to move this to prepare script. Unfortunately, we still support npm@2, and so we'll need to use both prepare and prepublish until we drop it (I think npm@4 is the first version with prepare).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant