-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release v1.543.0 #6257
Merged
Merged
chore: release v1.543.0 #6257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: unify Tx allowance logic * feat: cleaner * feat: refactor useIsApprovalNeeded to use a selector on allowanceCryptobaseUnit * feat: cleanup * feat: more cleanup * feat: cleanup * chore: do not inline types * feat: more cleanup * feat: cleanup unused type * feat: consume selectAllowanceCryptoBaseUnit in useIsApprovalNeeded * feat: extract GetAllowanceErr in react-queries/types --------- Co-authored-by: kaladinlight <[email protected]> Co-authored-by: Apotheosis <[email protected]>
Blocker: Not sure if a blocker but i have no unlocked loans that i can test the repay amount . Do we trust the withdraw that @gomesalexandre did when testing the PR itself? Discord testing thread: https://discord.com/channels/554694662431178782/1209280550926553118 |
3 tasks
fix: native allowance
The above blocker should be resolved by #6260. |
…#6265) * fix: allow quote sell amounts to be lower than user input sell amount * fix: fix logic, add a teeny tiny thrshold so cowswap works
3 tasks
blocker:
|
Non blocker: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: thorchain lending 100% repayment buffer (#6238)
feat: unify Tx allowance logic (#6217)
revert fix: temporarily disable eip-1559 for keepkey (#6254)
chore: bump hdwallet v1.53.4 (#6255)
chore: cut over nownodes prod (#6251)
feat: switch ethers JSON-RPC provider to StaticJsonRpcProvider (#6223)
fix: remove all hardcoded SwapperName.Thorchain in isTradingActive ch… (#6237)
chore: add validation for quotes with incorrect sell amount (#6241)
fix: trades from native assets & utxos (#6260)