Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump hdwallet v1.53.4 #6255

Merged
merged 2 commits into from
Feb 19, 2024
Merged

chore: bump hdwallet v1.53.4 #6255

merged 2 commits into from
Feb 19, 2024

Conversation

kaladinlight
Copy link
Contributor

Description

This hdwallet package bump disables EIP1559 fees on KeepKey.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

#6244

Risk

High Risk PRs Require 2 approvals

Low

What protocols, transaction types or contract interactions might be affected by this PR?

  • KeepKey wallet only

Testing

  • Ensure all evm transaction signed by KeepKey are legacy transactions (no EIP1559)

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

@kaladinlight kaladinlight requested a review from a team as a code owner February 19, 2024 22:06
@kaladinlight kaladinlight mentioned this pull request Feb 19, 2024
Merged
0xApotheosis
0xApotheosis approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a KeepKey on my person to test with, but this diff looks exactly how I expect it to look.

@kaladinlight kaladinlight enabled auto-merge (squash) February 19, 2024 22:19
@kaladinlight kaladinlight merged commit d0cf9c3 into develop Feb 19, 2024
3 checks passed
@kaladinlight kaladinlight deleted the hdwallet-v1.53.4 branch February 19, 2024 22:25
@0xApotheosis 0xApotheosis mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaladinlight @0xApotheosis