fix: allow quote sell amounts to be lower than user input sell amount #6265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xApotheosis
requested changes
Feb 20, 2024
0xApotheosis
approved these changes
Feb 20, 2024
0xApotheosis
added a commit
that referenced
this pull request
Feb 21, 2024
* fix: trades from native assets & utxos (#6260) fix: native allowance * fix: use correct chain id for matching buy account * fix: allow quote sell amounts to be lower than user input sell amount (#6265) * fix: allow quote sell amounts to be lower than user input sell amount * fix: fix logic, add a teeny tiny thrshold so cowswap works * fix: consolidate matching buy account id selection logic (#6268) * chore: fix merge --------- Co-authored-by: kaladinlight <[email protected]> Co-authored-by: woody <[email protected]>
gomesalexandre
pushed a commit
that referenced
this pull request
Feb 22, 2024
* fix: trades from native assets & utxos (#6260) fix: native allowance * fix: use correct chain id for matching buy account * fix: allow quote sell amounts to be lower than user input sell amount (#6265) * fix: allow quote sell amounts to be lower than user input sell amount * fix: fix logic, add a teeny tiny thrshold so cowswap works * fix: consolidate matching buy account id selection logic (#6268) * chore: fix merge --------- Co-authored-by: kaladinlight <[email protected]> Co-authored-by: woody <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where quotes with a sell amount LOWER than user input are marked as invalid (namely cowswap quotes). We need to allow this case, and only mark quotes selling an amount HIGHER than the user inputted value as invalid.
Pull Request Type
Issue (if applicable)
NA
Risk
Low risk of broken trade qutoes.
Testing
Check quotes are working generally
Check CowSwap quotes are working (e.g FOX -> ETH $30)
Engineering
Operations
Screenshots (if applicable)
Before fix
After fix
