Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow quote sell amounts to be lower than user input sell amount #6265

Merged
merged 2 commits into from
Feb 20, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/state/apis/swapper/helpers/validateTradeQuote.ts
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,9 @@ export const validateTradeQuote = async (
})()

// ensure the trade is not selling an amount higher than the user input
const invalidQuoteSellAmount =
inputSellAmountCryptoBaseUnit !== firstHop.sellAmountIncludingProtocolFeesCryptoBaseUnit
const invalidQuoteSellAmount = bn(inputSellAmountCryptoBaseUnit).gte(
firstHop.sellAmountIncludingProtocolFeesCryptoBaseUnit,
)

return {
errors: [
Expand Down
Loading