-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support Bootstrap 4 Beta #316
Conversation
Is there a good reason to even support the alpha? We'll eventually move to only support the released version. Reviewed 3 of 3 files at r1. Comments from Reviewable |
I think so. In my thoughts we can drop alpha in the next beta release If you think I have to drop alpha - will do |
Fixed source object name for user config
@IvanKalinin Great work!
Once the above 3 steps are done, I'll immediately create a new release for v2.2.0. Reviewed 1 of 1 files at r2. .bootstraprc-4-default, line 10 at r2 (raw file):
remove .bootstraprc-4-default, line 63 at r2 (raw file):
Remove src/bootstrap.config.js, line 130 at r2 (raw file):
Do we still need this key? what purpose is it? src/bootstrap.styles.loader.js, line 25 at r2 (raw file):
remove src/bootstrap.styles.loader.js, line 50 at r2 (raw file):
remove conditional for beta Comments from Reviewable |
There are a bit more changes. |
Just one question in the code, that probably requires a doc note. Please confirm all examples work and I'll merge and release. GREAT WORK! Reviewed 23 of 23 files at r3. examples/basic/.bootstraprc-4-example, line 13 at r3 (raw file):
Why did this change? Just curious. Should we document this in the CHANGELOG or README? This is pretty subtle. Comments from Reviewable |
Because order matters. Postcss loader should work after sass-loader. In that order there is no errors and warnings in console. And yes, I tried all three examples with bs4 |
@justin808 any news when the PR will merged ? |
Review status: all files reviewed at latest revision, 6 unresolved discussions. Comments from Reviewable |
Thanks @IvanKalinin! |
Yes, thanks @IvanKalinin |
I still found issue : Argument |
@kuongknight maybe submit a PR? |
This change is