Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.bootstraprc Webpack loaders order is incorrect #160

Closed
laisvarejao opened this issue Dec 4, 2017 · 4 comments
Closed

.bootstraprc Webpack loaders order is incorrect #160

laisvarejao opened this issue Dec 4, 2017 · 4 comments
Labels

Comments

@laisvarejao
Copy link
Contributor

laisvarejao commented Dec 4, 2017

Right now the configuration has - postcss after - sass. However, this way the autoprefixer doesn't work. The correct order is:

# Webpack loaders, order matters
styleLoaders:
  - style-loader
  - css-loader
  - postcss-loader
  - sass-loader
@laisvarejao laisvarejao added the bug label Dec 7, 2017
@chocoelho
Copy link
Contributor

@laisvarejao did you check shakacode/bootstrap-loader#316 (comment)? Here it was said why that change was made.

@chocoelho
Copy link
Contributor

chocoelho commented Dec 14, 2017

Also, shouldn't they have the -loader suffix? Since Webpack 2, it was said that this would change.

    BREAKING CHANGE: It's no longer allowed to omit the '-loader' prefix when using loaders.
                     You need to specify 'style-loader' instead of 'style'.

@laisvarejao
Copy link
Contributor Author

@chocoelho yes, I believe you're correct about the -loadersuffix. And yes, I saw the discussion about the why the order matters. However, when testing here, setting the postcss-loader below the sass-loader does not autoprefix the properties.

I don't know if another configuration is wrong :(

@lucabezerra
Copy link
Contributor

@laisvarejao @chocoelho is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants