-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bootstrap version #151
Conversation
Signed-off-by: Carlos Coelho <[email protected]>
Signed-off-by: Carlos Coelho <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chocoelho
Did you check the changes in shakacode/bootstrap-loader#316 ?
I only did a quick look but a few changes that might require researching into why they made them:
- Removed
responsive-embed: true
from .bootstraprc-4-default - Removed
useFlexbox: true
and all mentions/documentation of it. We useuseFlexbox: false
. Does that still work? I think this won't work because of this change. If so, how can we disable it and do we still have a valid reason to disable it? Maybe @laisvarejao can help. - They changed the order of
sass-loader
andpostcss-loader
in their example. They might have had a good reason to do it.
If you have taken those into consideration and they don't require any further changes disconsider it.
Signed-off-by: Carlos Coelho <[email protected]>
Signed-off-by: Carlos Coelho <[email protected]>
Thanks, @aericson. I also noticed that I had forgotten to include Popper.js configuration in webpack. As to what you said:
|
@aericson where did you see that the order of the sass-loader and postcss-loader changed? @aericson @chocoelho yes, Flexbox is now the only option! This has changed since Alpha 6:
|
@laisvarejao about the changed order: shakacode/bootstrap-loader#316 (comment) |
Regarding the alphabetic order, that can be done as well and I agree with it. |
Signed-off-by: Carlos Coelho <[email protected]>
Description
This PR updates supported Bootstrap 4 version from alpha to beta.
normalize
was removed from beta version, so we don't need that in.bootstraprc
anymore.Motivation and Context
Resolves #125. We upgrade from alpha to beta version of Bootstrap 4.
Types of changes
Checklist: