Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] deprecate phred_base(phred_type) constructor #2588

Merged
merged 1 commit into from
May 4, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented May 2, 2021

@marehr marehr requested review from a team and SGSSGene and removed request for a team May 2, 2021 13:48
@vercel
Copy link

vercel bot commented May 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/GLyVNhyQNsu4D8bJ67e6jAiWoNhj
✅ Preview: https://seqan3-git-fork-marehr-deprecatephred-seqan.vercel.app

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #2588 (6097987) into master (54379f9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2588   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         269      269           
  Lines       10561    10561           
=======================================
  Hits        10375    10375           
  Misses        186      186           
Impacted Files Coverage Δ
include/seqan3/alphabet/quality/phred42.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/quality/phred63.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/quality/phred68solexa.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/quality/phred94.hpp 100.00% <ø> (ø)
include/seqan3/alphabet/quality/phred_base.hpp 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54379f9...6097987. Read the comment docs.

Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work without flaw. But why replace the call to the base call with assign_phred. Any advantages or more personal taste?

@SGSSGene SGSSGene requested review from a team and eseiler and removed request for a team May 4, 2021 10:39
@marehr
Copy link
Member Author

marehr commented May 4, 2021

Should work without flaw. But why replace the call to the base call with assign_phred. Any advantages or more personal taste?

To workaround annoying deprecation warnings xD

@eseiler eseiler merged commit d0074ea into seqan:master May 4, 2021
@marehr marehr deleted the deprecate_phred branch May 4, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants