Merge pull request #2588 from marehr/deprecate_phred

[MISC] deprecate phred_base(phred_type) constructor
seqan · May 4, 2021 · d0074ea · d0074ea · vercel · May 4, 2021
2 parents ff1d53e + 6097987
commit d0074ea
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 5 deletions.
diff --git a/include/seqan3/alphabet/quality/phred42.hpp b/include/seqan3/alphabet/quality/phred42.hpp
@@ -70,7 +70,10 @@ class phred42 : public phred_base<phred42, 42>
      * \details
      * \deprecated This will be removed in 3.1.0. Please use seqan3::phred42::assign_phred() or '!'_phred42.
      */
-    SEQAN3_DEPRECATED_310 constexpr phred42(phred_type const p) : base_t{p} {}
+    SEQAN3_DEPRECATED_310 constexpr phred42(phred_type const p)
+    {
+        assign_phred(p);
+    }
 
     // Inherit converting constructor
     using base_t::base_t;

diff --git a/include/seqan3/alphabet/quality/phred63.hpp b/include/seqan3/alphabet/quality/phred63.hpp
@@ -70,7 +70,10 @@ class phred63 : public phred_base<phred63, 63>
      * \details
      * \deprecated This will be removed in 3.1.0. Please use seqan3::phred63::assign_phred() or '!'_phred63.
      */
-    SEQAN3_DEPRECATED_310 constexpr phred63(phred_type const p) : base_t{p} {}
+    SEQAN3_DEPRECATED_310 constexpr phred63(phred_type const p)
+    {
+        assign_phred(p);
+    }
 
     // Inherit converting constructor
     using base_t::base_t;

diff --git a/include/seqan3/alphabet/quality/phred68solexa.hpp b/include/seqan3/alphabet/quality/phred68solexa.hpp
@@ -63,7 +63,10 @@ class phred68solexa : public phred_base<phred68solexa, 68>
      * \details
      * \deprecated This will be removed in 3.1.0. Please use seqan3::phred68solexa::assign_phred() or '!'_phred68solexa.
      */
-    SEQAN3_DEPRECATED_310 constexpr phred68solexa(phred_type const p) : base_t{p} {}
+    SEQAN3_DEPRECATED_310 constexpr phred68solexa(phred_type const p)
+    {
+        assign_phred(p);
+    }
 
     // Inherit converting constructor
     using base_t::base_t;

diff --git a/include/seqan3/alphabet/quality/phred94.hpp b/include/seqan3/alphabet/quality/phred94.hpp
@@ -67,7 +67,10 @@ class phred94 : public phred_base<phred94, 94>
      * \details
      * \deprecated This will be removed in 3.1.0. Please use seqan3::phred94::assign_phred() or '!'_phred94.
      */
-    SEQAN3_DEPRECATED_310 constexpr phred94(phred_type const p) : base_t{p} {}
+    SEQAN3_DEPRECATED_310 constexpr phred94(phred_type const p)
+    {
+        assign_phred(p);
+    }
 
     // Inherit converting constructor
     using base_t::base_t;

diff --git a/include/seqan3/alphabet/quality/phred_base.hpp b/include/seqan3/alphabet/quality/phred_base.hpp
@@ -61,7 +61,7 @@ class phred_base : public alphabet_base<derived_type, size, char>
      * \details
      * \deprecated This will be removed in 3.1.0. Please use, e.g., seqan3::phred42{}.assign_phred(p) or '!'_phred42.
      */
-    constexpr phred_base(phred_type const p) noexcept
+    SEQAN3_DEPRECATED_310 constexpr phred_base(phred_type const p) noexcept
     {
         static_cast<derived_type *>(this)->assign_phred(p);
     }