Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] deprecate phred_base(phred_type) constructor #2588

Merged
merged 1 commit into from
May 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion include/seqan3/alphabet/quality/phred42.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ class phred42 : public phred_base<phred42, 42>
* \details
* \deprecated This will be removed in 3.1.0. Please use seqan3::phred42::assign_phred() or '!'_phred42.
*/
SEQAN3_DEPRECATED_310 constexpr phred42(phred_type const p) : base_t{p} {}
SEQAN3_DEPRECATED_310 constexpr phred42(phred_type const p)
{
assign_phred(p);
}

// Inherit converting constructor
using base_t::base_t;
Expand Down
5 changes: 4 additions & 1 deletion include/seqan3/alphabet/quality/phred63.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ class phred63 : public phred_base<phred63, 63>
* \details
* \deprecated This will be removed in 3.1.0. Please use seqan3::phred63::assign_phred() or '!'_phred63.
*/
SEQAN3_DEPRECATED_310 constexpr phred63(phred_type const p) : base_t{p} {}
SEQAN3_DEPRECATED_310 constexpr phred63(phred_type const p)
{
assign_phred(p);
}

// Inherit converting constructor
using base_t::base_t;
Expand Down
5 changes: 4 additions & 1 deletion include/seqan3/alphabet/quality/phred68solexa.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ class phred68solexa : public phred_base<phred68solexa, 68>
* \details
* \deprecated This will be removed in 3.1.0. Please use seqan3::phred68solexa::assign_phred() or '!'_phred68solexa.
*/
SEQAN3_DEPRECATED_310 constexpr phred68solexa(phred_type const p) : base_t{p} {}
SEQAN3_DEPRECATED_310 constexpr phred68solexa(phred_type const p)
{
assign_phred(p);
}

// Inherit converting constructor
using base_t::base_t;
Expand Down
5 changes: 4 additions & 1 deletion include/seqan3/alphabet/quality/phred94.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ class phred94 : public phred_base<phred94, 94>
* \details
* \deprecated This will be removed in 3.1.0. Please use seqan3::phred94::assign_phred() or '!'_phred94.
*/
SEQAN3_DEPRECATED_310 constexpr phred94(phred_type const p) : base_t{p} {}
SEQAN3_DEPRECATED_310 constexpr phred94(phred_type const p)
{
assign_phred(p);
}

// Inherit converting constructor
using base_t::base_t;
Expand Down
2 changes: 1 addition & 1 deletion include/seqan3/alphabet/quality/phred_base.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class phred_base : public alphabet_base<derived_type, size, char>
* \details
* \deprecated This will be removed in 3.1.0. Please use, e.g., seqan3::phred42{}.assign_phred(p) or '!'_phred42.
*/
constexpr phred_base(phred_type const p) noexcept
SEQAN3_DEPRECATED_310 constexpr phred_base(phred_type const p) noexcept
{
static_cast<derived_type *>(this)->assign_phred(p);
}
Expand Down