Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alignment Configuration] Enable free end gap config of method_global in policies. #2066

Conversation

smehringer
Copy link
Member

Extracted from #2032

Only the last commit is relevant

@smehringer smehringer requested a review from marehr August 20, 2020 11:58
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #2066 into release-3.0.2 will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-3.0.2    #2066      +/-   ##
=================================================
- Coverage          97.91%   97.91%   -0.01%     
=================================================
  Files                263      263              
  Lines               9894     9890       -4     
=================================================
- Hits                9688     9684       -4     
  Misses               206      206              
Impacted Files Coverage Δ
...nt/pairwise/detail/policy_affine_gap_recursion.hpp 100.00% <100.00%> (ø)
...gnment/pairwise/detail/policy_alignment_matrix.hpp 100.00% <100.00%> (ø)
...ignment/pairwise/detail/policy_optimum_tracker.hpp 96.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917d5d6...0072a04. Read the comment docs.

@marehr
Copy link
Member

marehr commented Aug 25, 2020

Copy link
Member

@marehr marehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last commit looks fine :)

@marehr
Copy link
Member

marehr commented Aug 25, 2020

(Can you rebase and solve the merge-conflict?)

@marehr marehr requested a review from eseiler August 25, 2020 10:19
@smehringer smehringer force-pushed the alignment_configuration_free_end_gaps_3 branch from f5a6d1b to 6c276da Compare August 25, 2020 13:01
@smehringer
Copy link
Member Author

Thanks for marking the PRs as blocked 👍

@smehringer smehringer force-pushed the alignment_configuration_free_end_gaps_3 branch from 6c276da to 0072a04 Compare August 27, 2020 06:06
@smehringer
Copy link
Member Author

Code coverage fail is unrelated

@smehringer smehringer merged commit 36d96cc into seqan:release-3.0.2 Aug 27, 2020
@smehringer smehringer deleted the alignment_configuration_free_end_gaps_3 branch September 24, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants