Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alignment Configuration] Change member variables of method_global to booleans. #2045

Conversation

smehringer
Copy link
Member

Applies requested change from #2032 in separate PR.

Part of #2032

@smehringer smehringer requested a review from marehr August 18, 2020 06:10
@smehringer smehringer force-pushed the alignment_configuration_free_end_gaps_1 branch from 94f603a to 78c6942 Compare August 18, 2020 07:33
@smehringer smehringer changed the base branch from master to release-3.0.2 August 18, 2020 07:35
Copy link
Member

@marehr marehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis is so good to review :)

@marehr marehr requested a review from rrahn August 18, 2020 08:37
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #2045 into release-3.0.2 will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-3.0.2    #2045      +/-   ##
=================================================
- Coverage          97.89%   97.89%   -0.01%     
=================================================
  Files                263      263              
  Lines               9879     9874       -5     
=================================================
- Hits                9671     9666       -5     
  Misses               208      208              
Impacted Files Coverage Δ
...n3/alignment/configuration/align_config_method.hpp 100.00% <ø> (ø)
include/seqan3/argument_parser/validators.hpp 88.82% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce0448...78c6942. Read the comment docs.

@smehringer
Copy link
Member Author

@rrahn early ping, but these PRs are really small and for the alignment free end gap configuration (I noticed to not mention that in the title and maybe you did not prioritize them)

@smehringer smehringer changed the title [MISC] Change member variables of method_global to booleans. [Alignment Configuration] Change member variables of method_global to booleans. Aug 20, 2020
@smehringer smehringer requested review from eseiler and removed request for rrahn August 24, 2020 09:15
@eseiler eseiler merged commit bd5a78e into seqan:release-3.0.2 Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants