Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alignment Configuration] Add free end gap configuration to method_global calls. #2046

Conversation

smehringer
Copy link
Member

Extracted from #2032

@smehringer smehringer requested a review from marehr August 18, 2020 06:11
@smehringer smehringer changed the base branch from master to release-3.0.2 August 18, 2020 07:35
Copy link
Member

@marehr marehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😄

@marehr marehr requested a review from rrahn August 18, 2020 08:39
@smehringer smehringer force-pushed the alignment_configuration_free_end_gaps_2 branch 2 times, most recently from adc8127 to a5debdf Compare August 19, 2020 09:26
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #2046 into release-3.0.2 will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-3.0.2    #2046      +/-   ##
=================================================
- Coverage          97.91%   97.89%   -0.03%     
=================================================
  Files                263      263              
  Lines               9887     9886       -1     
=================================================
- Hits                9681     9678       -3     
- Misses               206      208       +2     
Impacted Files Coverage Δ
.../seqan3/alignment/pairwise/alignment_algorithm.hpp 98.50% <0.00%> (-1.50%) ⬇️
...qan3/alignment/pairwise/edit_distance_unbanded.hpp 99.24% <0.00%> (-0.01%) ⬇️
...e/seqan3/alignment/pairwise/detail/type_traits.hpp 100.00% <0.00%> (ø)
...qan3/alignment/pairwise/alignment_configurator.hpp 100.00% <0.00%> (ø)
...n3/alignment/configuration/align_config_method.hpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b53bba3...9e32fe3. Read the comment docs.

@smehringer
Copy link
Member Author

@rrahn early ping, but these PRs are really small and for the alignment free end gap configuration (I noticed to not mention that in the title and maybe you did not prioritize them)

@smehringer smehringer changed the title [MISC] Add free end gap configuration to method_global calls. [Alignment Configuration] Add free end gap configuration to method_global calls. Aug 20, 2020
@smehringer smehringer requested review from eseiler and removed request for rrahn August 24, 2020 10:43
@smehringer smehringer force-pushed the alignment_configuration_free_end_gaps_2 branch from a5debdf to 9e32fe3 Compare August 24, 2020 10:57
@marehr
Copy link
Member

marehr commented Aug 24, 2020

jenkins = broken

@smehringer smehringer merged commit 026ab9e into seqan:release-3.0.2 Aug 25, 2020
@smehringer smehringer deleted the alignment_configuration_free_end_gaps_2 branch September 24, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants