Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bmw 631/add more info #48

Merged
merged 4 commits into from
May 9, 2023
Merged

Bmw 631/add more info #48

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b35d361
add topic & sensor name
May 9, 2023
d45f7fe
minor fix
May 9, 2023
60a9e72
change order
May 9, 2023
727a867
for safety
May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion output.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,13 @@ message SystemHealth {
SENSOR_TILTED = 3;
SENSOR_SUSPENDED = 4;
}
message SensorInfo {
SensorStatus status = 1;
string topic = 2;
string sensor_name = 3;
}
Status status = 1;
map<string, SensorStatus> sensors = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thor-sr @sebastian-seoul-robotics FYI, we output pairs of ROS topic and sensor status, where users have no idea about which topic corresponds to which lidar. Alex is changing the key to use the UID and putting extra info (e.g., lidar name in SENSR and topic name for backward compatibility). Here's the link to the relevant conversation: https://seoulrobotics.atlassian.net/browse/BMW-631?focusedCommentId=32983

map<string, SensorInfo> sensors = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be safe, let's reserve 3 and change the ID to 4. Reusing the id is strictly forbidden. Then this would not break the existing client applications.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds promising

}
Status master = 1;
map<string, Node> nodes = 2;
Expand Down