Bmw 631/add more info #48
Conversation
AlexSeongJu-sr
requested review from
young-seoulrobotics,
thor-sr and
sebastian-seoul-robotics
| Status status = 1; | ||
| map<string, SensorStatus> sensors = 3; |
There was a problem hiding this comment.
@thor-sr @sebastian-seoul-robotics FYI, we output pairs of ROS topic and sensor status, where users have no idea about which topic corresponds to which lidar. Alex is changing the key to use the UID and putting extra info (e.g., lidar name in SENSR and topic name for backward compatibility). Here's the link to the relevant conversation: https://seoulrobotics.atlassian.net/browse/BMW-631?focusedCommentId=32983
|
|
It will break backwards compatibility. As long as it not applied to sensr_i_release/3.1.x, there should not be a problem. The next release will be a major update (4.0). So no backwards compatibility required @mogandaz fyi |
|
so I guess it is fine to merge to master as long as I don't merge to sensr_i_release. |
output.proto
Outdated
| Status status = 1; | ||
| map<string, SensorStatus> sensors = 3; | ||
| map<string, SensorInfo> sensors = 3; |
There was a problem hiding this comment.
Just to be safe, let's reserve 3 and change the ID to 4. Reusing the id is strictly forbidden. Then this would not break the existing client applications.
There was a problem hiding this comment.
sounds promising
I feel like
map<string, string> extra_info
is rather messy.
so I just added sensor_name and topic.