-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn ContactImporter into ES6 class #542
Conversation
Also add `sendgrid` as a dependency so the test will run and pass. Resolves sendgrid#532
@@ -1,3 +1,4 @@ | |||
const sendgrid = require('sendgrid'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test file uses sendgrid, but it wasn't in the file. This was required to get it to run and pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add this script shortcut in main package json:
{
// ...
scripts: {
// ...
"test:contact": "babel-node ./node_modules/istanbul/lib/cli cover ./node_modules/mocha/bin/_mocha \"packages/contact-importer/**/*.spec.js\"",
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, I'll get that added shortly.
@rafaelverger ready for another review! |
All of them make sense to me... @mbernier ? |
This is awesome!! Thank you @sethetter and @rafaelverger -- SO AWESOME seeing you guys take this one on. Thank you Thank you Thank you!! |
Hello @sethetter and @rafaelverger , |
@mbernier @thinkingserious thank you both! Happy to contribute. Thanks @rafaelverger for the review! |
Also add
sendgrid
as a dependency so the test will run and pass.Resolves #532