Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn ContactImporter into ES6 class #542

Merged
merged 3 commits into from
Oct 28, 2017

Conversation

sethetter
Copy link
Contributor

Also add sendgrid as a dependency so the test will run and pass.

Resolves #532

Also add `sendgrid` as a dependency so the test will run and pass.

Resolves sendgrid#532
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 25, 2017

CLA assistant check
All committers have signed the CLA.

@@ -1,3 +1,4 @@
const sendgrid = require('sendgrid');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test file uses sendgrid, but it wasn't in the file. This was required to get it to run and pass.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add this script shortcut in main package json:

{
  // ...
  scripts: {
    // ... 
    "test:contact": "babel-node ./node_modules/istanbul/lib/cli cover ./node_modules/mocha/bin/_mocha \"packages/contact-importer/**/*.spec.js\"",
  }
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'll get that added shortly.

@sethetter
Copy link
Contributor Author

@rafaelverger ready for another review!

@rafaelverger
Copy link
Contributor

All of them make sense to me... @mbernier ?

@mbernier
Copy link
Contributor

This is awesome!! Thank you @sethetter and @rafaelverger -- SO AWESOME seeing you guys take this one on. Thank you Thank you Thank you!!

@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 28, 2017
@mbernier mbernier merged commit d2192d8 into sendgrid:master Oct 28, 2017
@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 28, 2017

Hello @sethetter and @rafaelverger ,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@sethetter
Copy link
Contributor Author

@mbernier @thinkingserious thank you both! Happy to contribute. Thanks @rafaelverger for the review!

@sethetter sethetter deleted the 532-es6-contact-importer branch October 28, 2017 17:23
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@thinkingserious thinkingserious mentioned this pull request Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants