Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceError: sendgrid is not defined while running tests #541

Closed
divyanshu013 opened this issue Oct 25, 2017 · 1 comment
Closed

ReferenceError: sendgrid is not defined while running tests #541

divyanshu013 opened this issue Oct 25, 2017 · 1 comment

Comments

@divyanshu013
Copy link
Contributor

Issue Summary

I'm getting the following error while setting up the repo and running yarn test:

yarn run v1.2.1
$ npm run test:all -s


  test_contact_importer
    1) "before each" hook for "test_contact_importer sends items in batches"


  0 passing (7ms)
  1 failing

  1) test_contact_importer "before each" hook for "test_contact_importer sends items in batches":
     ReferenceError: sendgrid is not defined
      at Context.<anonymous> (packages/contact-importer/src/importer.spec.js:2:89)

Steps to Reproduce

  1. Clone the repo
  2. Install dependencies
  3. Set up api key
  4. Run tests yarn test

I think this is probably because of this statement which causes sendgrid is not defined. A require of the correct package will probably fix this.

Let me know if I can help further or send a PR for this

Technical details:

  • sendgrid-nodejs Version: master (latest commit: 094260f)
  • Node.js Version: v8.6.0
  • Ubuntu 16.04 (linux x64)
@mbernier mbernier removed difficulty: easy fix is easy in difficulty difficulty: hard fix is hard in difficulty difficulty: medium fix is medium in difficulty labels Oct 27, 2017
@rafaelverger
Copy link
Contributor

PR #542 solves it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants