Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES6-ify contact importer #532

Closed
mbernier opened this issue Oct 24, 2017 · 1 comment
Closed

ES6-ify contact importer #532

mbernier opened this issue Oct 24, 2017 · 1 comment
Labels
status: help wanted requesting help from the community

Comments

@mbernier
Copy link
Contributor

Issue Summary

Refactor the contact importer to make more use of ES6 standards
@mbernier mbernier added difficulty: hard fix is hard in difficulty hacktoberfest labels Oct 24, 2017
itaditya added a commit to itaditya/sendgrid-nodejs that referenced this issue Oct 24, 2017
@itaditya
fixes sendgrid#532
d0b0a32
sethetter added a commit to sethetter/sendgrid-nodejs that referenced this issue Oct 25, 2017
@sethetter
Turn ContactImporter into ES6 class
8b91269 
Also add `sendgrid` as a dependency so the test will run and pass.

Resolves sendgrid#532
@sethetter sethetter mentioned this issue Oct 25, 2017
Merged
@itaditya
Copy link
Contributor

@mbernier, please review it.

@mbernier mbernier removed difficulty: easy fix is easy in difficulty difficulty: hard fix is hard in difficulty difficulty: medium fix is medium in difficulty labels Oct 27, 2017
@childish-sambino childish-sambino added status: help wanted requesting help from the community and removed help wanted labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted requesting help from the community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbernier @itaditya @childish-sambino