(feat): resolving asv env explicitly

Cargo.toml

@@ -30,6 +30,7 @@ tokio = { version = "1.36.0", features = ["rt-multi-thread", "process"] }
 tower-http = { version = "0.5.1", features = ["trace"] }
 tracing = "0.1.40"
 tracing-subscriber = "0.3.18"
+serde_json = "1.0"
 
 [target.'cfg(target_os = "linux")'.dependencies]
 libsystemd = "0.7.0"
@@ -41,7 +42,6 @@ temp-env = "0.3.6"
 test-temp-dir = "0.2.0"
 # transitive deps we use directly
 http = "1.0.0"
-serde_json = "1.0"
 hmac-sha256 = "1.1.7"
 hex = "0.4.3"
 tower = "0.4.13"

README.md

@@ -48,6 +48,8 @@ All these currently assume you have a <samp>&lt;user></samp> login with sudo rig
    micromamba run -n asv asv machine --yes
    ```
 
+   (use `micromamba activate asv` to make `asv` available in your PATH)
+
 2. Update `LoadCredentialEncrypted` lines in <samp>benchmark.service</samp> using
 
    ```shell

scripts/test.nu

@@ -1,12 +1,13 @@
-# Source this file using `source test.nu`, then run e.g.:
+# In one shell run:
 #
 # ```nushell
 # cargo run -- --dry-run serve --secret-token "It's a Secret to Everybody"
 # ```
 #
-# and in another shell:
+# After installing `jaq` and `libgcrypt` in another nushell (activated via the `nu` command after installation), run the following:
 #
 # ```nushell
+# source test.nu
 # gh-hook http://localhost:3000/ (open ./src/fixtures/test.hook-pr-sync.json) --full --allow-errors
 # ```
 

src/benchmark.rs

@@ -90,6 +90,24 @@ impl AsvCompare {
     }
 }
 
+pub async fn resolve_env(wd: &Path) -> Result<Vec<String>> {
+    tracing::info!("Resolving Environments: {:?}", wd);
+    resolve_env_from_stdout(
+        Command::new("python")
+            .current_dir(wd)
+            .args(["-c", include_str!("resolve_env.py")]),
+    )
+    .await
+}
+
+async fn resolve_env_from_stdout(command: &mut Command) -> Result<Vec<String>> {
+    let stdout_env_specs_buffer = command.output().await?.stdout;
+    let stdout_env_specs = String::from_utf8(stdout_env_specs_buffer)?;
+    let parsed: Vec<String> = serde_json::from_str(&stdout_env_specs)?;
+    tracing::info!("Found environments: {:?}", parsed);
+    Ok(parsed)
+}
+
 async fn run_benchmark(repo: git2::Repository, on: &[String]) -> Result<PathBuf> {
     let wd = {
         let on = on.to_owned();
@@ -110,6 +128,10 @@ async fn run_benchmark(repo: git2::Repository, on: &[String]) -> Result<PathBuf>
     tracing::info!("Running asv in {}", wd.display());
     let mut command = asv_command(&wd);
     command.arg("run"); // This skips even if benchmarks changed: .arg("--skip-existing-commits");
+    let env_specs = resolve_env(&wd).await?;
+    for env_spec in env_specs {
+        command.args(["-E", &env_spec]);
+    }
     let mut child = if on.is_empty() {
         command.spawn().context("failed to spawn `asv run`")?
     } else {
@@ -173,3 +195,41 @@ fn fetch_configured_refs(repo: &git2::Repository, refs: &[String]) -> Result<Pat
     }
     Ok(wd)
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[tokio::test]
+    async fn test_resolve_env() {
+        let resolved_envs =
+            resolve_env_from_stdout(Command::new("echo").arg("[\"env0\", \"env1\", \"env2\"]"))
+                .await
+                .expect("Parsing unexpectedly failed for echo-ing a list of strings.");
+        assert_eq!(resolved_envs, vec!["env0", "env1", "env2"]);
+    }
+
+    #[tokio::test]
+    async fn test_resolve_env_empty_json() {
+        let resolved_envs = resolve_env_from_stdout(Command::new("echo").arg("[]"))
+            .await
+            .expect("Parsing unexpectedly failed for echo-ing an empty list.");
+        assert_eq!(resolved_envs.len(), 0);
+    }
+
+    #[tokio::test]
+    async fn test_resolve_env_crash_integer_list() {
+        let e = resolve_env_from_stdout(Command::new("echo").arg("[1, 2, 3]"))
+            .await
+            .expect_err("Integer list is not an expected type");
+        assert!(format!("{e:?}").contains("invalid type: integer `1`, expected a string"));
+    }
+
+    #[tokio::test]
+    async fn test_resolve_env_crash_bad_command() {
+        let e = resolve_env_from_stdout(&mut Command::new("echolllll"))
+            .await
+            .expect_err("echolllll should return an error");
+        assert!(format!("{e:?}").starts_with("No such file or directory (os error 2)"));
+    }
+}

src/resolve_env.py

@@ -0,0 +1,5 @@
+import asv
+import json
+conf = asv.config.Config.load("asv.conf.json")
+env_names = [env.name for env in asv.environment.get_environments(conf, "")]
+print(json.dumps(env_names))