-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): resolving asv
env explicitly
#35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just some nitpicks, assuming you want them: There’s two possible ways to make the Python script nicer, and the tests can be a bit more concise.
For further unit tests in this vein, I wonder if we should look into mocking. But that’s for another day.
Co-authored-by: Philipp A. <[email protected]>
…erse/benchmark into ig/resolve_env_functionality
for more information, see https://pre-commit.ci
Co-authored-by: Philipp A. <[email protected]>
Thanks so much for my first rust review @flying-sheep 😄
I briefly looked into it, but it seemed like too much of a rabbit hole for right now, agreed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I unified the tests a little, looks great!
Fixes #31
So obviously this python string business is not ideal but I am not sure what else to do. The python file doesn't copy over with the build after compilation so as far as I can tell we can do it manually or it's PyO3.