Integration branch ux 12.2024 #8988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UEPR-67] restyle community guidelines page
feat: [UEPR-90] Added new section to the ideas page
refactor: [UEPR-90] fixed gap between components and how pdfs open
Bug: [UEPR-108] admin panel visibility
feat: [UEPR-48] redesign welcome section
…und-playback bug: [UEPR-118] Player sound playback
feat: [UEPR-121] add new banner with link to ideas project
feat: [UEPR-116] add youtube video playlists and open videos in modal
feat: [UEPR-88] added modal for written guides
MiroslavDionisiev
approved these changes
Dec 4, 2024
cwillisf
reviewed
Dec 10, 2024
| <div className={classNames('admin-panel', className, {hidden: !isOpen})}> | ||
| <div className={classNames('admin-panel', className, {collapsed: !isOpen})}> |
| <img | ||
| alt="Get Started" | ||
| src="/images/welcome-learn.png" | ||
| alt="Starter Projects" |
There was a problem hiding this comment.
Future improvement: alt attributes should use intl.formatMessage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
Debug modal and Ideas page bundle
https://scratchfoundation.atlassian.net/wiki/spaces/SET/pages/edit-v2/798720010
Changes:
Describe what this Pull Request does. Be sure to include a brief description of the issue the Pull Requests solves too.
Test Coverage:
Please show how you have added tests to cover your changes or describe how you have tested the changes (include a screenshot if possible).