bug: [UEPR-118] Player sound playback #8980
Conversation
Bogomil-Stoyanov
changed the base branch from
develop
to
integration-branch-ux-12.2024
src/components/intro/intro.jsx
Outdated
| @@ -75,6 +72,12 @@ class Intro extends React.Component { | |||
| </div> | |||
| ) | |||
| } | |||
|
|
|||
| <Video | |||
| className={classnames('intro-videos', !this.state.videoOpen && 'invisible')} | |||
There was a problem hiding this comment.
Do we need the invisible class if we don't render the video component when this.state.videoOpen is false?
There was a problem hiding this comment.
Isn't this taken out of the this.state.videoOpen check?
There was a problem hiding this comment.
The goal is to ensure that the video component fully loads before it is displayed. The bug occurred because the player was not properly initialized, causing the video to start playing before the player was ready.
I am not exactly sure why it is happening
There was a problem hiding this comment.
I removed the style, it was left behind from another previous solution that I tried
| @@ -35,44 +40,53 @@ class Video extends React.Component { | |||
| onReady: video => { | |||
| video.bind('play', () => { | |||
| this.setState({videoStarted: true}); | |||
| this.props.onVideoStart(); | |||
| if (this.props.onVideoStart) { | |||
There was a problem hiding this comment.
I am wondering whether it would be better to give onVideoStart a default value. But I don't mind it either way
There was a problem hiding this comment.
Before that there wasn't even a check, it was just straight up throwing an error in the console 😅
Bogomil-Stoyanov
merged commit b975170
into
scratchfoundation:integration-branch-ux-12.2024
Jira ticket:
UEPR-118