feat: [UEPR-90] Added new section to the ideas page #8873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KManolov3
reviewed
Nov 8, 2024
src/views/ideas/l10n.json
Outdated
| @@ -4,7 +4,11 @@ | |||
| "ideas.headerButtonMessage": "Choose a tutorial", | |||
| "ideas.gettingStartedTitle": "Getting Started", | |||
| "ideas.gettingStartedText": "New to Scratch? Try the Getting Started tutorial.", | |||
There was a problem hiding this comment.
Can we remove unused translations from here, if there are any
KManolov3
reviewed
Nov 8, 2024
src/views/ideas/ideas.scss
Outdated
| } | ||
| .tips-button { | ||
| display: flex; | ||
| flex-direction: row; |
There was a problem hiding this comment.
Isn't row the default direction?
KManolov3
approved these changes
Nov 8, 2024
KManolov3
changed the base branch from
develop
to
integration-branch-ux-12.2024
mxmou
reviewed
Nov 14, 2024
Comment on lines
-38
to
-41
| .banner-button { | ||
| background-color: $ui-white; | ||
| color: $ui-aqua; | ||
| font-size: 1rem; |
There was a problem hiding this comment.
Were these styles intentionally removed? ideas.jsx still references this class (line 104).
There was a problem hiding this comment.
Yes, the intent for this task was to redesign the header as well but the content team delayed providing some links so we will handle it separately.
MiroslavDionisiev
merged commit 0cc1091
into
scratchfoundation:integration-branch-ux-12.2024
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket:
UEPR-90
Changes:
Added new sections to ideas page, removed old ones, changed the page component from class to functional one.
Test Coverage:
Please show how you have added tests to cover your changes or describe how you have tested the changes (include a screenshot if possible).
