Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore flow translation #360

Merged
merged 7 commits into from
Oct 3, 2022
Merged

fix: ignore flow translation #360

merged 7 commits into from
Oct 3, 2022

Conversation

scolladon
Copy link
Owner

What does this pull request contain?


  • Added (for new features).
  • Changed (for changes in existing functionality).
  • Deprecated (for soon-to-be removed features).
  • Removed (for now removed features).
  • Fixed (for any bug fixes).
  • Security (for vulnerability fixes).

Explain your changes


Create a ignoreHelper to be the adapter with the ignore module
It stores ignore instances per ignore file path (destructive and additive)
Make the ignore instances map static and use lazy loading to build it
Refactor repoGitDiff using the new ignoreHelper
Use the new helper in the flowTranslationProcessor module

Does this close any currently open issues?


closes #359

  • Jest test added to check the fix is applied.

@scolladon scolladon requested a review from mehdicherf as a code owner October 2, 2022 12:50
@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (5463169) compared to base (263e37d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        30    +1     
  Lines          735       767   +32     
=========================================
+ Hits           735       767   +32     
Impacted Files Coverage Δ
src/post-processor/flowTranslationProcessor.js 100.00% <100.00%> (ø)
src/post-processor/postProcessorManager.js 100.00% <100.00%> (ø)
src/utils/fsHelper.js 100.00% <100.00%> (ø)
src/utils/ignoreHelper.js 100.00% <100.00%> (ø)
src/utils/repoGitDiff.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeclimate
Copy link

codeclimate bot commented Oct 2, 2022

Code Climate has analyzed commit 5463169 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@mehdicherf mehdicherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scolladon scolladon merged commit a24536d into main Oct 3, 2022
@scolladon scolladon deleted the fix/ignore-flow-translation branch October 3, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.forceignore failing to exclude "Translations" (latest working version: v5.3.1)
2 participants