Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.forceignore failing to exclude "Translations" (latest working version: v5.3.1) #359

Closed
patrykzak opened this issue Sep 29, 2022 · 4 comments · Fixed by #360
Closed

.forceignore failing to exclude "Translations" (latest working version: v5.3.1) #359

patrykzak opened this issue Sep 29, 2022 · 4 comments · Fixed by #360
Assignees
Labels
bug Something isn't working

Comments

@patrykzak
Copy link

patrykzak commented Sep 29, 2022

I observed today that translations are coming back to generated package.xml even though they are mentioned in .forceignore file, I have installed previous version v5.3.1 and in that version it's working as expected.
Kindly please fix that issue, maybe there are more metadata, but I only encountered this one

@patrykzak patrykzak added the bug Something isn't working label Sep 29, 2022
@scolladon
Copy link
Owner

scolladon commented Sep 29, 2022

Hi @patrykzak

Thanks for raising this issue and helping improving the plugin.

I think this issue maybe related to this recent enhancement #321
This change allow to add the translation when there is a translation for a flow and a flow has been modified.
Because if not pushing the translation at the same time of the flow it seems to remove previous translations.

What you experience is that you have translation in the package whereas it should be ignored because you are using -i with the .forceignore file with explicit ignore of the translations here, is that correct ?

Does your changes includes translations ?

@patrykzak
Copy link
Author

@scolladon thanks for quick response, what you stated in your message is correct.
I have translations changes in my pull request, I use -i .forceignore where I specify that translations should be ignored, however generated package still contains translations.

@mehdicherf
Copy link
Collaborator

Hi!

This is something we discussed with @scolladon today, and I agree with you @patrykzak: since you explicitly ignored the translations through the ignore file, it should not be part of the SGD output.

The new feature to add automatically the translations when there is a change in a related flow (#322) is a great default behaviour. But when it conflicts with the content of the ignore files, the latter should win.

Stay tuned for a fix in the next version :-)

@scolladon
Copy link
Owner

We just released the version 5.5.1 @patrykzak with this fix
You can install it using the latest-rc tag:

$ sfdx plugins:install sfdx-git-delta@latest-rc

Let us know if everything is working following the expectations, we will make it the latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants