Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BatchProcessJobDefinition metadata #364

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

scolladon
Copy link
Owner

@scolladon scolladon commented Oct 7, 2022

What does this pull request contain?


  • Added (for new features).
  • Changed (for changes in existing functionality).
  • Deprecated (for soon-to-be removed features).
  • Removed (for now removed features).
  • Fixed (for any bug fixes).
  • Security (for vulnerability fixes).

Explain your changes


add BatchProcessJobDefinition metadata for API version 51+

Does this close any currently open issues?


closes #363

@scolladon scolladon requested a review from mehdicherf as a code owner October 7, 2022 14:29
@codeclimate
Copy link

codeclimate bot commented Oct 7, 2022

Code Climate has analyzed commit b4bf5bc and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b4bf5bc) compared to base (a24536d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #364   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          767       767           
=========================================
  Hits           767       767           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@mehdicherf mehdicherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Seb!

@scolladon scolladon merged commit 5882ab2 into main Oct 7, 2022
@scolladon scolladon deleted the feat/add-batchprocessjobdefinition branch October 7, 2022 15:57
@domimpact
Copy link

domimpact commented Oct 8, 2022

@scolladon Could you please do a release. Thanks!

@scolladon
Copy link
Owner Author

@domimpact

TL;DR we are working on it 👍

We don't know yet if we do a release right now, because we have other features cooking we may want to ship altogether
And if we release it will also contain a fix which we want to be sure it will not bring regression.
We also try to avoid shipping feature on weekend, to avoid having to deal with regression during those low availability days.

You need it soon ? Can it wait beginning of next week ?

@domimpact
Copy link

domimpact commented Oct 8, 2022

No problem, it can wait beginning of next week. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BatchProcessJobDefinition metadata
3 participants